Commit 2875ca92 authored by Tony Luck's avatar Tony Luck

[IA64] fix(?) unwind data for ia64_monarch_init_handler

Roland> I can see the ERROR: comes from unwcheck.pl but I have no
Roland> idea what it is checking (something to do with unwind info?)
Roland> let alone how to fix the problem.

Roland> Is this benign or is there something to be fixed?

David> Both: it needs to be fixed, but it's (mostly) benign since the only
David> time we're executing that code is when the unwinder can't run anyhow,
David> since we're in the middle of delivering an MCA.  That may (and
David> probably will) change in the future, so it's something that should be
David> fixed.

David> I was hoping someone who knows and could test the MCA code better
David> would fix it but that hasn't happened yet, so it's time for plan B.

David> Tony, below is a patch that fixes the unwind info enough that the
David> warning/error goes away.  The unwind-info may not be 100% correct
David> though.  Someone who can test/exercise this code may want to check on
David> that.
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
parent 7fb8db68
...@@ -868,7 +868,7 @@ end_os_mca_restore: ...@@ -868,7 +868,7 @@ end_os_mca_restore:
GLOBAL_ENTRY(ia64_monarch_init_handler) GLOBAL_ENTRY(ia64_monarch_init_handler)
.prologue
// stash the information the SAL passed to os // stash the information the SAL passed to os
SAL_TO_OS_MCA_HANDOFF_STATE_SAVE(r2) SAL_TO_OS_MCA_HANDOFF_STATE_SAVE(r2)
;; ;;
...@@ -907,6 +907,7 @@ IVirtual_Switch: ...@@ -907,6 +907,7 @@ IVirtual_Switch:
adds out0=16,sp // out0 = pointer to pt_regs adds out0=16,sp // out0 = pointer to pt_regs
;; ;;
DO_SAVE_SWITCH_STACK DO_SAVE_SWITCH_STACK
.body
adds out1=16,sp // out0 = pointer to switch_stack adds out1=16,sp // out0 = pointer to switch_stack
br.call.sptk.many rp=ia64_init_handler br.call.sptk.many rp=ia64_init_handler
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment