Commit 28cb6ccd authored by Nicolas Kaiser's avatar Nicolas Kaiser Committed by David S. Miller

gianfar: fix signedness issue

irq_of_parse_and_map() has an unsigned return type.
Testing for a negative error value doesn't work here.
Signed-off-by: default avatarNicolas Kaiser <nikai@nikai.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 870634b0
...@@ -577,12 +577,11 @@ static int gfar_parse_group(struct device_node *np, ...@@ -577,12 +577,11 @@ static int gfar_parse_group(struct device_node *np,
irq_of_parse_and_map(np, 1); irq_of_parse_and_map(np, 1);
priv->gfargrp[priv->num_grps].interruptError = priv->gfargrp[priv->num_grps].interruptError =
irq_of_parse_and_map(np,2); irq_of_parse_and_map(np,2);
if (priv->gfargrp[priv->num_grps].interruptTransmit < 0 || if (priv->gfargrp[priv->num_grps].interruptTransmit == NO_IRQ ||
priv->gfargrp[priv->num_grps].interruptReceive < 0 || priv->gfargrp[priv->num_grps].interruptReceive == NO_IRQ ||
priv->gfargrp[priv->num_grps].interruptError < 0) { priv->gfargrp[priv->num_grps].interruptError == NO_IRQ)
return -EINVAL; return -EINVAL;
} }
}
priv->gfargrp[priv->num_grps].grp_id = priv->num_grps; priv->gfargrp[priv->num_grps].grp_id = priv->num_grps;
priv->gfargrp[priv->num_grps].priv = priv; priv->gfargrp[priv->num_grps].priv = priv;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment