Commit 291bc793 authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Bartosz Golaszewski

gpio: omap: Remove redundant dev_err_probe() and zero value handle code

There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

And the code to handle bank->irq = 0 is redundant because
platform_get_irq() do not return 0.
Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 92f7a358
...@@ -1412,11 +1412,8 @@ static int omap_gpio_probe(struct platform_device *pdev) ...@@ -1412,11 +1412,8 @@ static int omap_gpio_probe(struct platform_device *pdev)
bank->dev = dev; bank->dev = dev;
bank->irq = platform_get_irq(pdev, 0); bank->irq = platform_get_irq(pdev, 0);
if (bank->irq <= 0) { if (bank->irq < 0)
if (!bank->irq) return bank->irq;
bank->irq = -ENXIO;
return dev_err_probe(dev, bank->irq, "can't get irq resource\n");
}
bank->chip.parent = dev; bank->chip.parent = dev;
bank->chip.owner = THIS_MODULE; bank->chip.owner = THIS_MODULE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment