Commit 2a760554 authored by Minghao Chi (CGEL ZTE)'s avatar Minghao Chi (CGEL ZTE) Committed by David S. Miller

net:mcf8390: Use platform_get_irq() to get the interrupt

It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
for requesting IRQ's resources any more, as they can be not ready yet in
case of DT-booting.

platform_get_irq() instead is a recommended way for getting IRQ even if
it was not retrieved earlier.

It also makes code simpler because we're getting "int" value right away
and no conversion from resource to int is required.
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarMinghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6babfc6e
...@@ -405,12 +405,12 @@ static int mcf8390_init(struct net_device *dev) ...@@ -405,12 +405,12 @@ static int mcf8390_init(struct net_device *dev)
static int mcf8390_probe(struct platform_device *pdev) static int mcf8390_probe(struct platform_device *pdev)
{ {
struct net_device *dev; struct net_device *dev;
struct resource *mem, *irq; struct resource *mem;
resource_size_t msize; resource_size_t msize;
int ret; int ret, irq;
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); irq = platform_get_irq(pdev, 0);
if (irq == NULL) { if (irq < 0) {
dev_err(&pdev->dev, "no IRQ specified?\n"); dev_err(&pdev->dev, "no IRQ specified?\n");
return -ENXIO; return -ENXIO;
} }
...@@ -433,7 +433,7 @@ static int mcf8390_probe(struct platform_device *pdev) ...@@ -433,7 +433,7 @@ static int mcf8390_probe(struct platform_device *pdev)
SET_NETDEV_DEV(dev, &pdev->dev); SET_NETDEV_DEV(dev, &pdev->dev);
platform_set_drvdata(pdev, dev); platform_set_drvdata(pdev, dev);
dev->irq = irq->start; dev->irq = irq;
dev->base_addr = mem->start; dev->base_addr = mem->start;
ret = mcf8390_init(dev); ret = mcf8390_init(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment