Commit 2b33e191 authored by Sam Ravnborg's avatar Sam Ravnborg

drm/panel: ilitek-ili9881c: use drm_panel backlight support

Use the backlight support in drm_panel to simplify the driver
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191207140353.23967-10-sam@ravnborg.org
parent e3e4944f
...@@ -3,7 +3,6 @@ ...@@ -3,7 +3,6 @@
* Copyright (C) 2017-2018, Bootlin * Copyright (C) 2017-2018, Bootlin
*/ */
#include <linux/backlight.h>
#include <linux/delay.h> #include <linux/delay.h>
#include <linux/device.h> #include <linux/device.h>
#include <linux/err.h> #include <linux/err.h>
...@@ -25,7 +24,6 @@ struct ili9881c { ...@@ -25,7 +24,6 @@ struct ili9881c {
struct drm_panel panel; struct drm_panel panel;
struct mipi_dsi_device *dsi; struct mipi_dsi_device *dsi;
struct backlight_device *backlight;
struct regulator *power; struct regulator *power;
struct gpio_desc *reset; struct gpio_desc *reset;
}; };
...@@ -348,7 +346,6 @@ static int ili9881c_enable(struct drm_panel *panel) ...@@ -348,7 +346,6 @@ static int ili9881c_enable(struct drm_panel *panel)
msleep(120); msleep(120);
mipi_dsi_dcs_set_display_on(ctx->dsi); mipi_dsi_dcs_set_display_on(ctx->dsi);
backlight_enable(ctx->backlight);
return 0; return 0;
} }
...@@ -357,7 +354,6 @@ static int ili9881c_disable(struct drm_panel *panel) ...@@ -357,7 +354,6 @@ static int ili9881c_disable(struct drm_panel *panel)
{ {
struct ili9881c *ctx = panel_to_ili9881c(panel); struct ili9881c *ctx = panel_to_ili9881c(panel);
backlight_disable(ctx->backlight);
return mipi_dsi_dcs_set_display_off(ctx->dsi); return mipi_dsi_dcs_set_display_off(ctx->dsi);
} }
...@@ -423,7 +419,6 @@ static const struct drm_panel_funcs ili9881c_funcs = { ...@@ -423,7 +419,6 @@ static const struct drm_panel_funcs ili9881c_funcs = {
static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi) static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
{ {
struct device_node *np;
struct ili9881c *ctx; struct ili9881c *ctx;
int ret; int ret;
...@@ -448,14 +443,9 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi) ...@@ -448,14 +443,9 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
return PTR_ERR(ctx->reset); return PTR_ERR(ctx->reset);
} }
np = of_parse_phandle(dsi->dev.of_node, "backlight", 0); ret = drm_panel_of_backlight(&ctx->panel);
if (np) { if (ret)
ctx->backlight = of_find_backlight_by_node(np); return ret;
of_node_put(np);
if (!ctx->backlight)
return -EPROBE_DEFER;
}
ret = drm_panel_add(&ctx->panel); ret = drm_panel_add(&ctx->panel);
if (ret < 0) if (ret < 0)
...@@ -475,9 +465,6 @@ static int ili9881c_dsi_remove(struct mipi_dsi_device *dsi) ...@@ -475,9 +465,6 @@ static int ili9881c_dsi_remove(struct mipi_dsi_device *dsi)
mipi_dsi_detach(dsi); mipi_dsi_detach(dsi);
drm_panel_remove(&ctx->panel); drm_panel_remove(&ctx->panel);
if (ctx->backlight)
put_device(&ctx->backlight->dev);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment