Commit 2b83d3de authored by Trond Myklebust's avatar Trond Myklebust

NFSv4/pnfs: Ensure we don't miss a file extension

pNFS writes don't return attributes, however that doesn't mean that we
should ignore the fact that they may be extending the file. This patch
ensures that if a write is seen to extend the file, then we always set
an attribute barrier, and update the cached file size.
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 3c38cbe2
...@@ -1378,24 +1378,27 @@ static void nfs_writeback_check_extend(struct nfs_pgio_header *hdr, ...@@ -1378,24 +1378,27 @@ static void nfs_writeback_check_extend(struct nfs_pgio_header *hdr,
{ {
struct nfs_pgio_args *argp = &hdr->args; struct nfs_pgio_args *argp = &hdr->args;
struct nfs_pgio_res *resp = &hdr->res; struct nfs_pgio_res *resp = &hdr->res;
u64 size = argp->offset + resp->count;
if (!(fattr->valid & NFS_ATTR_FATTR_SIZE)) if (!(fattr->valid & NFS_ATTR_FATTR_SIZE))
fattr->size = size;
if (nfs_size_to_loff_t(fattr->size) < i_size_read(hdr->inode)) {
fattr->valid &= ~NFS_ATTR_FATTR_SIZE;
return; return;
if (argp->offset + resp->count != fattr->size) }
return; if (size != fattr->size)
if (nfs_size_to_loff_t(fattr->size) < i_size_read(hdr->inode))
return; return;
/* Set attribute barrier */ /* Set attribute barrier */
nfs_fattr_set_barrier(fattr); nfs_fattr_set_barrier(fattr);
/* ...and update size */
fattr->valid |= NFS_ATTR_FATTR_SIZE;
} }
void nfs_writeback_update_inode(struct nfs_pgio_header *hdr) void nfs_writeback_update_inode(struct nfs_pgio_header *hdr)
{ {
struct nfs_fattr *fattr = hdr->res.fattr; struct nfs_fattr *fattr = &hdr->fattr;
struct inode *inode = hdr->inode; struct inode *inode = hdr->inode;
if (fattr == NULL)
return;
spin_lock(&inode->i_lock); spin_lock(&inode->i_lock);
nfs_writeback_check_extend(hdr, fattr); nfs_writeback_check_extend(hdr, fattr);
nfs_post_op_update_inode_force_wcc_locked(inode, fattr); nfs_post_op_update_inode_force_wcc_locked(inode, fattr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment