Commit 2b87c267 authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron

iio: dac: ds4424: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-4-caihuoqing@baidu.comSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 7bb9df2d
...@@ -232,12 +232,9 @@ static int ds4424_probe(struct i2c_client *client, ...@@ -232,12 +232,9 @@ static int ds4424_probe(struct i2c_client *client,
indio_dev->name = id->name; indio_dev->name = id->name;
data->vcc_reg = devm_regulator_get(&client->dev, "vcc"); data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
if (IS_ERR(data->vcc_reg)) { if (IS_ERR(data->vcc_reg))
dev_err(&client->dev, return dev_err_probe(&client->dev, PTR_ERR(data->vcc_reg),
"Failed to get vcc-supply regulator. err: %ld\n", "Failed to get vcc-supply regulator.\n");
PTR_ERR(data->vcc_reg));
return PTR_ERR(data->vcc_reg);
}
mutex_init(&data->lock); mutex_init(&data->lock);
ret = regulator_enable(data->vcc_reg); ret = regulator_enable(data->vcc_reg);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment