Commit 2ed37f6c authored by Markus Elfring's avatar Markus Elfring Committed by Nicholas Bellinger

target: Deletion of unnecessary checks before the function call "module_put"

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent e7b7af6e
...@@ -26,7 +26,6 @@ struct iscsit_transport *iscsit_get_transport(int type) ...@@ -26,7 +26,6 @@ struct iscsit_transport *iscsit_get_transport(int type)
void iscsit_put_transport(struct iscsit_transport *t) void iscsit_put_transport(struct iscsit_transport *t)
{ {
if (t->owner)
module_put(t->owner); module_put(t->owner);
} }
......
...@@ -137,7 +137,6 @@ core_alloc_hba(const char *plugin_name, u32 plugin_dep_id, u32 hba_flags) ...@@ -137,7 +137,6 @@ core_alloc_hba(const char *plugin_name, u32 plugin_dep_id, u32 hba_flags)
return hba; return hba;
out_module_put: out_module_put:
if (hba->transport->owner)
module_put(hba->transport->owner); module_put(hba->transport->owner);
hba->transport = NULL; hba->transport = NULL;
out_free_hba: out_free_hba:
...@@ -159,7 +158,6 @@ core_delete_hba(struct se_hba *hba) ...@@ -159,7 +158,6 @@ core_delete_hba(struct se_hba *hba)
pr_debug("CORE_HBA[%d] - Detached HBA from Generic Target" pr_debug("CORE_HBA[%d] - Detached HBA from Generic Target"
" Core\n", hba->hba_id); " Core\n", hba->hba_id);
if (hba->transport->owner)
module_put(hba->transport->owner); module_put(hba->transport->owner);
hba->transport = NULL; hba->transport = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment