Commit 2ee1cc70 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Greg Kroah-Hartman

firmware: vpd: do not leak kobjects

kobject_del() only unlinks kobject, we need to use kobject_put() to
make sure kobject will go away completely.

Fixes: 049a59db ("firmware: Google VPD sysfs driver")
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ce57cba3
...@@ -244,7 +244,7 @@ static int vpd_section_destroy(struct vpd_section *sec) ...@@ -244,7 +244,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
{ {
if (sec->enabled) { if (sec->enabled) {
vpd_section_attrib_destroy(sec); vpd_section_attrib_destroy(sec);
kobject_del(sec->kobj); kobject_put(sec->kobj);
sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr); sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr);
kfree(sec->raw_name); kfree(sec->raw_name);
iounmap(sec->baseaddr); iounmap(sec->baseaddr);
...@@ -331,7 +331,7 @@ static void __exit vpd_platform_exit(void) ...@@ -331,7 +331,7 @@ static void __exit vpd_platform_exit(void)
{ {
vpd_section_destroy(&ro_vpd); vpd_section_destroy(&ro_vpd);
vpd_section_destroy(&rw_vpd); vpd_section_destroy(&rw_vpd);
kobject_del(vpd_kobj); kobject_put(vpd_kobj);
} }
module_init(vpd_platform_init); module_init(vpd_platform_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment