Commit 2f63b011 authored by Juuso Oikarinen's avatar Juuso Oikarinen Committed by Luciano Coelho

wl1271: Remove outdated FIXME's

Remove outdated FIXME's from the code.
Signed-off-by: default avatarJuuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: default avatarLuciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: default avatarLuciano Coelho <luciano.coelho@nokia.com>
parent fa21c7a9
...@@ -251,8 +251,10 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl) ...@@ -251,8 +251,10 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl)
burst_len = nvs_ptr[0]; burst_len = nvs_ptr[0];
dest_addr = (nvs_ptr[1] & 0xfe) | ((u32)(nvs_ptr[2] << 8)); dest_addr = (nvs_ptr[1] & 0xfe) | ((u32)(nvs_ptr[2] << 8));
/* FIXME: Due to our new wl1271_translate_reg_addr function, /*
we need to add the REGISTER_BASE to the destination */ * Due to our new wl1271_translate_reg_addr function,
* we need to add the REGISTER_BASE to the destination
*/
dest_addr += REGISTERS_BASE; dest_addr += REGISTERS_BASE;
/* We move our pointer to the data */ /* We move our pointer to the data */
...@@ -280,8 +282,6 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl) ...@@ -280,8 +282,6 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl)
ALIGN(nvs_ptr - (u8 *)wl->nvs->nvs + 7, 4); ALIGN(nvs_ptr - (u8 *)wl->nvs->nvs + 7, 4);
nvs_len -= nvs_ptr - (u8 *)wl->nvs->nvs; nvs_len -= nvs_ptr - (u8 *)wl->nvs->nvs;
/* FIXME: The driver sets the partition here, but this is not needed,
since it sets to the same one as currently in use */
/* Now we must set the partition correctly */ /* Now we must set the partition correctly */
wl1271_set_partition(wl, &part_table[PART_WORK]); wl1271_set_partition(wl, &part_table[PART_WORK]);
...@@ -291,9 +291,6 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl) ...@@ -291,9 +291,6 @@ static int wl1271_boot_upload_nvs(struct wl1271 *wl)
return -ENOMEM; return -ENOMEM;
/* And finally we upload the NVS tables */ /* And finally we upload the NVS tables */
/* FIXME: In wl1271, we upload everything at once.
No endianness handling needed here?! The ref driver doesn't do
anything about it at this point */
wl1271_write(wl, CMD_MBOX_ADDRESS, nvs_aligned, nvs_len, false); wl1271_write(wl, CMD_MBOX_ADDRESS, nvs_aligned, nvs_len, false);
kfree(nvs_aligned); kfree(nvs_aligned);
...@@ -491,10 +488,7 @@ int wl1271_boot(struct wl1271 *wl) ...@@ -491,10 +488,7 @@ int wl1271_boot(struct wl1271 *wl)
wl1271_debug(DEBUG_BOOT, "pause1 0x%x", pause); wl1271_debug(DEBUG_BOOT, "pause1 0x%x", pause);
pause &= ~(WU_COUNTER_PAUSE_VAL); /* FIXME: This should probably be pause &= ~(WU_COUNTER_PAUSE_VAL);
* WU_COUNTER_PAUSE_VAL instead of
* 0x3ff (magic number ). How does
* this work?! */
pause |= WU_COUNTER_PAUSE_VAL; pause |= WU_COUNTER_PAUSE_VAL;
wl1271_write32(wl, WU_COUNTER_PAUSE, pause); wl1271_write32(wl, WU_COUNTER_PAUSE, pause);
...@@ -548,7 +542,6 @@ int wl1271_boot(struct wl1271 *wl) ...@@ -548,7 +542,6 @@ int wl1271_boot(struct wl1271 *wl)
if (ret < 0) if (ret < 0)
goto out; goto out;
/* FIXME: Need to check whether this is really what we want */
wl1271_write32(wl, ACX_REG_INTERRUPT_MASK, wl1271_write32(wl, ACX_REG_INTERRUPT_MASK,
WL1271_ACX_ALL_EVENTS_VECTOR); WL1271_ACX_ALL_EVENTS_VECTOR);
......
...@@ -251,7 +251,6 @@ static struct conf_drv_settings default_conf = { ...@@ -251,7 +251,6 @@ static struct conf_drv_settings default_conf = {
.host_fast_wakeup_support = false .host_fast_wakeup_support = false
}, },
.roam_trigger = { .roam_trigger = {
/* FIXME: due to firmware bug, must use value 1 for now */
.trigger_pacing = 1, .trigger_pacing = 1,
.avg_weight_rssi_beacon = 20, .avg_weight_rssi_beacon = 20,
.avg_weight_rssi_data = 10, .avg_weight_rssi_data = 10,
...@@ -2281,8 +2280,7 @@ static ssize_t wl1271_sysfs_show_bt_coex_state(struct device *dev, ...@@ -2281,8 +2280,7 @@ static ssize_t wl1271_sysfs_show_bt_coex_state(struct device *dev,
struct wl1271 *wl = dev_get_drvdata(dev); struct wl1271 *wl = dev_get_drvdata(dev);
ssize_t len; ssize_t len;
/* FIXME: what's the maximum length of buf? page size?*/ len = PAGE_SIZE;
len = 500;
mutex_lock(&wl->mutex); mutex_lock(&wl->mutex);
len = snprintf(buf, len, "%d\n\n0 - off\n1 - on\n", len = snprintf(buf, len, "%d\n\n0 - off\n1 - on\n",
...@@ -2343,8 +2341,7 @@ static ssize_t wl1271_sysfs_show_hw_pg_ver(struct device *dev, ...@@ -2343,8 +2341,7 @@ static ssize_t wl1271_sysfs_show_hw_pg_ver(struct device *dev,
struct wl1271 *wl = dev_get_drvdata(dev); struct wl1271 *wl = dev_get_drvdata(dev);
ssize_t len; ssize_t len;
/* FIXME: what's the maximum length of buf? page size?*/ len = PAGE_SIZE;
len = 500;
mutex_lock(&wl->mutex); mutex_lock(&wl->mutex);
if (wl->hw_pg_ver >= 0) if (wl->hw_pg_ver >= 0)
......
...@@ -422,8 +422,6 @@ void wl1271_tx_reset(struct wl1271 *wl) ...@@ -422,8 +422,6 @@ void wl1271_tx_reset(struct wl1271 *wl)
struct sk_buff *skb; struct sk_buff *skb;
/* TX failure */ /* TX failure */
/* control->flags = 0; FIXME */
while ((skb = skb_dequeue(&wl->tx_queue))) { while ((skb = skb_dequeue(&wl->tx_queue))) {
wl1271_debug(DEBUG_TX, "freeing skb 0x%p", skb); wl1271_debug(DEBUG_TX, "freeing skb 0x%p", skb);
ieee80211_tx_status(wl->hw, skb); ieee80211_tx_status(wl->hw, skb);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment