Commit 2fc458f7 authored by Adrian Hunter's avatar Adrian Hunter Committed by Ulf Hansson

mmc: au1xmmc: Replace kmap_atomic() with kmap_local_page()

kmap_local_page() is equivalent to kmap_atomic() except that it does not
disable page faults or preemption. Where possible kmap_local_page() is
preferred to kmap_atomic() - refer kernel highmem documentation.

In this case, there is no need to disable page faults or preemption, so
replace kmap_atomic() with kmap_local_page(), and, correspondingly,
kunmap_atomic() with kunmap_local().
Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20221005101951.3165-14-adrian.hunter@intel.comSigned-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 8e8d695f
...@@ -388,7 +388,7 @@ static void au1xmmc_send_pio(struct au1xmmc_host *host) ...@@ -388,7 +388,7 @@ static void au1xmmc_send_pio(struct au1xmmc_host *host)
/* This is the pointer to the data buffer */ /* This is the pointer to the data buffer */
sg = &data->sg[host->pio.index]; sg = &data->sg[host->pio.index];
sg_ptr = kmap_atomic(sg_page(sg)) + sg->offset + host->pio.offset; sg_ptr = kmap_local_page(sg_page(sg)) + sg->offset + host->pio.offset;
/* This is the space left inside the buffer */ /* This is the space left inside the buffer */
sg_len = data->sg[host->pio.index].length - host->pio.offset; sg_len = data->sg[host->pio.index].length - host->pio.offset;
...@@ -409,7 +409,7 @@ static void au1xmmc_send_pio(struct au1xmmc_host *host) ...@@ -409,7 +409,7 @@ static void au1xmmc_send_pio(struct au1xmmc_host *host)
__raw_writel((unsigned long)val, HOST_TXPORT(host)); __raw_writel((unsigned long)val, HOST_TXPORT(host));
wmb(); /* drain writebuffer */ wmb(); /* drain writebuffer */
} }
kunmap_atomic(sg_ptr); kunmap_local(sg_ptr);
host->pio.len -= count; host->pio.len -= count;
host->pio.offset += count; host->pio.offset += count;
...@@ -446,7 +446,7 @@ static void au1xmmc_receive_pio(struct au1xmmc_host *host) ...@@ -446,7 +446,7 @@ static void au1xmmc_receive_pio(struct au1xmmc_host *host)
if (host->pio.index < host->dma.len) { if (host->pio.index < host->dma.len) {
sg = &data->sg[host->pio.index]; sg = &data->sg[host->pio.index];
sg_ptr = kmap_atomic(sg_page(sg)) + sg->offset + host->pio.offset; sg_ptr = kmap_local_page(sg_page(sg)) + sg->offset + host->pio.offset;
/* This is the space left inside the buffer */ /* This is the space left inside the buffer */
sg_len = sg_dma_len(&data->sg[host->pio.index]) - host->pio.offset; sg_len = sg_dma_len(&data->sg[host->pio.index]) - host->pio.offset;
...@@ -488,7 +488,7 @@ static void au1xmmc_receive_pio(struct au1xmmc_host *host) ...@@ -488,7 +488,7 @@ static void au1xmmc_receive_pio(struct au1xmmc_host *host)
sg_ptr[count] = (unsigned char)(val & 0xFF); sg_ptr[count] = (unsigned char)(val & 0xFF);
} }
if (sg_ptr) if (sg_ptr)
kunmap_atomic(sg_ptr); kunmap_local(sg_ptr);
host->pio.len -= count; host->pio.len -= count;
host->pio.offset += count; host->pio.offset += count;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment