Commit 31431fe7 authored by David S. Miller's avatar David S. Miller

[SPARC64]: Fix SMP cpu bringup bug when bigkernel.

We have to load the bigkernel second TLB entry on
secondary processors before we move over the use
the kernel trap table.  Otherwise we can take a
TLB miss somewhere in the post-4MB area and the
TLB handler is not prepared to service that.

The case that usually occurs is the prom_set_trap_table
call made by trampoline.S, since p1275buf usually sits
very near the end of the kernel image.  It worked by
luck most of the time as long as p1275buf sits within
a single page since earlier code running in trampoline.S
forced that TLB entry to be loaded by the OBP TLB miss
handler.

This was not fun to figure out.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cfc894b6
...@@ -103,15 +103,6 @@ extern void inherit_locked_prom_mappings(int save_p); ...@@ -103,15 +103,6 @@ extern void inherit_locked_prom_mappings(int save_p);
void __init smp_callin(void) void __init smp_callin(void)
{ {
int cpuid = hard_smp_processor_id(); int cpuid = hard_smp_processor_id();
extern int bigkernel;
extern unsigned long kern_locked_tte_data;
if (bigkernel) {
prom_dtlb_load(sparc64_highest_locked_tlbent()-1,
kern_locked_tte_data + 0x400000, KERNBASE + 0x400000);
prom_itlb_load(sparc64_highest_locked_tlbent()-1,
kern_locked_tte_data + 0x400000, KERNBASE + 0x400000);
}
inherit_locked_prom_mappings(0); inherit_locked_prom_mappings(0);
......
...@@ -90,7 +90,9 @@ startup_continue: ...@@ -90,7 +90,9 @@ startup_continue:
sllx %g2, 32, %g2 sllx %g2, 32, %g2
wr %g2, 0, %tick_cmpr wr %g2, 0, %tick_cmpr
/* Call OBP by hand to lock KERNBASE into i/d tlbs. */ /* Call OBP by hand to lock KERNBASE into i/d tlbs.
* We lock 2 consequetive entries if we are 'bigkernel'.
*/
mov %o0, %l0 mov %o0, %l0
sethi %hi(prom_entry_lock), %g2 sethi %hi(prom_entry_lock), %g2
...@@ -136,6 +138,46 @@ startup_continue: ...@@ -136,6 +138,46 @@ startup_continue:
call %o1 call %o1
add %sp, (2047 + 128), %o0 add %sp, (2047 + 128), %o0
sethi %hi(bigkernel), %g2
lduw [%g2 + %lo(bigkernel)], %g2
cmp %g2, 0
be,pt %icc, do_dtlb
nop
sethi %hi(call_method), %g2
or %g2, %lo(call_method), %g2
stx %g2, [%sp + 2047 + 128 + 0x00]
mov 5, %g2
stx %g2, [%sp + 2047 + 128 + 0x08]
mov 1, %g2
stx %g2, [%sp + 2047 + 128 + 0x10]
sethi %hi(itlb_load), %g2
or %g2, %lo(itlb_load), %g2
stx %g2, [%sp + 2047 + 128 + 0x18]
sethi %hi(mmu_ihandle_cache), %g2
lduw [%g2 + %lo(mmu_ihandle_cache)], %g2
stx %g2, [%sp + 2047 + 128 + 0x20]
sethi %hi(KERNBASE + 0x400000), %g2
stx %g2, [%sp + 2047 + 128 + 0x28]
sethi %hi(kern_locked_tte_data), %g2
ldx [%g2 + %lo(kern_locked_tte_data)], %g2
sethi %hi(0x400000), %g1
add %g2, %g1, %g2
stx %g2, [%sp + 2047 + 128 + 0x30]
mov 14, %g2
BRANCH_IF_ANY_CHEETAH(g1,g5,1f)
mov 62, %g2
1:
stx %g2, [%sp + 2047 + 128 + 0x38]
sethi %hi(p1275buf), %g2
or %g2, %lo(p1275buf), %g2
ldx [%g2 + 0x08], %o1
call %o1
add %sp, (2047 + 128), %o0
do_dtlb:
sethi %hi(call_method), %g2 sethi %hi(call_method), %g2
or %g2, %lo(call_method), %g2 or %g2, %lo(call_method), %g2
stx %g2, [%sp + 2047 + 128 + 0x00] stx %g2, [%sp + 2047 + 128 + 0x00]
...@@ -168,6 +210,47 @@ startup_continue: ...@@ -168,6 +210,47 @@ startup_continue:
call %o1 call %o1
add %sp, (2047 + 128), %o0 add %sp, (2047 + 128), %o0
sethi %hi(bigkernel), %g2
lduw [%g2 + %lo(bigkernel)], %g2
cmp %g2, 0
be,pt %icc, do_unlock
nop
sethi %hi(call_method), %g2
or %g2, %lo(call_method), %g2
stx %g2, [%sp + 2047 + 128 + 0x00]
mov 5, %g2
stx %g2, [%sp + 2047 + 128 + 0x08]
mov 1, %g2
stx %g2, [%sp + 2047 + 128 + 0x10]
sethi %hi(dtlb_load), %g2
or %g2, %lo(dtlb_load), %g2
stx %g2, [%sp + 2047 + 128 + 0x18]
sethi %hi(mmu_ihandle_cache), %g2
lduw [%g2 + %lo(mmu_ihandle_cache)], %g2
stx %g2, [%sp + 2047 + 128 + 0x20]
sethi %hi(KERNBASE + 0x400000), %g2
stx %g2, [%sp + 2047 + 128 + 0x28]
sethi %hi(kern_locked_tte_data), %g2
ldx [%g2 + %lo(kern_locked_tte_data)], %g2
sethi %hi(0x400000), %g1
add %g2, %g1, %g2
stx %g2, [%sp + 2047 + 128 + 0x30]
mov 14, %g2
BRANCH_IF_ANY_CHEETAH(g1,g5,1f)
mov 62, %g2
1:
stx %g2, [%sp + 2047 + 128 + 0x38]
sethi %hi(p1275buf), %g2
or %g2, %lo(p1275buf), %g2
ldx [%g2 + 0x08], %o1
call %o1
add %sp, (2047 + 128), %o0
do_unlock:
sethi %hi(prom_entry_lock), %g2 sethi %hi(prom_entry_lock), %g2
stb %g0, [%g2 + %lo(prom_entry_lock)] stb %g0, [%g2 + %lo(prom_entry_lock)]
membar #StoreStore | #StoreLoad membar #StoreStore | #StoreLoad
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment