Commit 321a64b3 authored by Daniel Müller's avatar Daniel Müller Committed by Andrii Nakryiko

selftests/bpf: Check whether to run selftest

The sockopt test invokes test__start_subtest and then unconditionally
asserts the success. That means that even if deny-listed, any test will
still run and potentially fail.
Evaluate the return value of test__start_subtest() to achieve the
desired behavior, as other tests do.
Signed-off-by: default avatarDaniel Müller <deso@posteo.net>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20230525232248.640465-1-deso@posteo.net
parent 4c857a71
...@@ -1060,7 +1060,9 @@ void test_sockopt(void) ...@@ -1060,7 +1060,9 @@ void test_sockopt(void)
return; return;
for (i = 0; i < ARRAY_SIZE(tests); i++) { for (i = 0; i < ARRAY_SIZE(tests); i++) {
test__start_subtest(tests[i].descr); if (!test__start_subtest(tests[i].descr))
continue;
ASSERT_OK(run_test(cgroup_fd, &tests[i]), tests[i].descr); ASSERT_OK(run_test(cgroup_fd, &tests[i]), tests[i].descr);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment