Commit 35e22e49 authored by Parthasarathy Bhuvaragan's avatar Parthasarathy Bhuvaragan Committed by David S. Miller

tipc: fix cleanup at module unload

In tipc_server_stop(), we iterate over the connections with limiting
factor as server's idr_in_use. We ignore the fact that this variable
is decremented in tipc_close_conn(), leading to premature exit.

In this commit, we iterate until the we have no connections left.
Acked-by: default avatarYing Xue <ying.xue@windriver.com>
Acked-by: default avatarJon Maloy <jon.maloy@ericsson.com>
Tested-by: default avatarJohn Thompson <thompa.atl@gmail.com>
Signed-off-by: default avatarParthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4c887aa6
...@@ -619,14 +619,12 @@ int tipc_server_start(struct tipc_server *s) ...@@ -619,14 +619,12 @@ int tipc_server_start(struct tipc_server *s)
void tipc_server_stop(struct tipc_server *s) void tipc_server_stop(struct tipc_server *s)
{ {
struct tipc_conn *con; struct tipc_conn *con;
int total = 0;
int id; int id;
spin_lock_bh(&s->idr_lock); spin_lock_bh(&s->idr_lock);
for (id = 0; total < s->idr_in_use; id++) { for (id = 0; s->idr_in_use; id++) {
con = idr_find(&s->conn_idr, id); con = idr_find(&s->conn_idr, id);
if (con) { if (con) {
total++;
spin_unlock_bh(&s->idr_lock); spin_unlock_bh(&s->idr_lock);
tipc_close_conn(con); tipc_close_conn(con);
spin_lock_bh(&s->idr_lock); spin_lock_bh(&s->idr_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment