Commit 399562fc authored by Biju Das's avatar Biju Das Committed by Robert Foss

drm: adv7511: Add max_lane_freq_khz variable to struct adv7511_chip_info

The ADV7533 supports a maximum lane clock of 800MHz whereas it is 891MHz
for ADV7535. Add max_lane_freq_khz variable to struct adv7511_chip_info to
handle this difference.

While at it, drop the unused local variable max_lane_freq.
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230830142358.275459-4-biju.das.jz@bp.renesas.com
parent 11ae4e40
...@@ -336,6 +336,7 @@ enum adv7511_type { ...@@ -336,6 +336,7 @@ enum adv7511_type {
struct adv7511_chip_info { struct adv7511_chip_info {
enum adv7511_type type; enum adv7511_type type;
unsigned int max_mode_clock_khz; unsigned int max_mode_clock_khz;
unsigned int max_lane_freq_khz;
}; };
struct adv7511 { struct adv7511 {
......
...@@ -1370,11 +1370,13 @@ static const struct adv7511_chip_info adv7511_chip_info = { ...@@ -1370,11 +1370,13 @@ static const struct adv7511_chip_info adv7511_chip_info = {
static const struct adv7511_chip_info adv7533_chip_info = { static const struct adv7511_chip_info adv7533_chip_info = {
.type = ADV7533, .type = ADV7533,
.max_mode_clock_khz = 80000, .max_mode_clock_khz = 80000,
.max_lane_freq_khz = 800000,
}; };
static const struct adv7511_chip_info adv7535_chip_info = { static const struct adv7511_chip_info adv7535_chip_info = {
.type = ADV7535, .type = ADV7535,
.max_mode_clock_khz = 148500, .max_mode_clock_khz = 148500,
.max_lane_freq_khz = 891000,
}; };
static const struct i2c_device_id adv7511_i2c_ids[] = { static const struct i2c_device_id adv7511_i2c_ids[] = {
......
...@@ -103,7 +103,6 @@ void adv7533_dsi_power_off(struct adv7511 *adv) ...@@ -103,7 +103,6 @@ void adv7533_dsi_power_off(struct adv7511 *adv)
enum drm_mode_status adv7533_mode_valid(struct adv7511 *adv, enum drm_mode_status adv7533_mode_valid(struct adv7511 *adv,
const struct drm_display_mode *mode) const struct drm_display_mode *mode)
{ {
unsigned long max_lane_freq;
struct mipi_dsi_device *dsi = adv->dsi; struct mipi_dsi_device *dsi = adv->dsi;
u8 bpp = mipi_dsi_pixel_format_to_bpp(dsi->format); u8 bpp = mipi_dsi_pixel_format_to_bpp(dsi->format);
...@@ -112,9 +111,7 @@ enum drm_mode_status adv7533_mode_valid(struct adv7511 *adv, ...@@ -112,9 +111,7 @@ enum drm_mode_status adv7533_mode_valid(struct adv7511 *adv,
return MODE_CLOCK_HIGH; return MODE_CLOCK_HIGH;
/* Check max clock for each lane */ /* Check max clock for each lane */
max_lane_freq = (adv->info->type == ADV7533 ? 800000 : 891000); if (mode->clock * bpp > adv->info->max_lane_freq_khz * adv->num_dsi_lanes)
if (mode->clock * bpp > max_lane_freq * adv->num_dsi_lanes)
return MODE_CLOCK_HIGH; return MODE_CLOCK_HIGH;
return MODE_OK; return MODE_OK;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment