Commit 3af3d772 authored by zhangyi (F)'s avatar zhangyi (F) Committed by Jens Axboe

block_dump: remove block_dump feature

We have already delete block_dump feature in mark_inode_dirty() because
it can be replaced by tracepoints, now we also remove the part in
submit_bio() for the same reason. The part of block dump feature in
submit_bio() dump the write process, write region and sectors on the
target disk into kernel message. it can be replaced by
block_bio_queue tracepoint in submit_bio_checks(), so we do not need
block_dump anymore, remove the whole block_dump feature.
Signed-off-by: default avatarzhangyi (F) <yi.zhang@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210313030146.2882027-3-yi.zhang@huawei.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 12e06137
...@@ -1086,15 +1086,6 @@ blk_qc_t submit_bio(struct bio *bio) ...@@ -1086,15 +1086,6 @@ blk_qc_t submit_bio(struct bio *bio)
task_io_account_read(bio->bi_iter.bi_size); task_io_account_read(bio->bi_iter.bi_size);
count_vm_events(PGPGIN, count); count_vm_events(PGPGIN, count);
} }
if (unlikely(block_dump)) {
char b[BDEVNAME_SIZE];
printk(KERN_DEBUG "%s(%d): %s block %Lu on %s (%u sectors)\n",
current->comm, task_pid_nr(current),
op_is_write(bio_op(bio)) ? "WRITE" : "READ",
(unsigned long long)bio->bi_iter.bi_sector,
bio_devname(bio, b), count);
}
} }
/* /*
......
...@@ -360,7 +360,6 @@ extern unsigned int dirty_writeback_interval; ...@@ -360,7 +360,6 @@ extern unsigned int dirty_writeback_interval;
extern unsigned int dirty_expire_interval; extern unsigned int dirty_expire_interval;
extern unsigned int dirtytime_expire_interval; extern unsigned int dirtytime_expire_interval;
extern int vm_highmem_is_dirtyable; extern int vm_highmem_is_dirtyable;
extern int block_dump;
extern int laptop_mode; extern int laptop_mode;
int dirty_background_ratio_handler(struct ctl_table *table, int write, int dirty_background_ratio_handler(struct ctl_table *table, int write,
......
...@@ -2931,14 +2931,6 @@ static struct ctl_table vm_table[] = { ...@@ -2931,14 +2931,6 @@ static struct ctl_table vm_table[] = {
.mode = 0644, .mode = 0644,
.proc_handler = proc_dointvec_jiffies, .proc_handler = proc_dointvec_jiffies,
}, },
{
.procname = "block_dump",
.data = &block_dump,
.maxlen = sizeof(block_dump),
.mode = 0644,
.proc_handler = proc_dointvec_minmax,
.extra1 = SYSCTL_ZERO,
},
{ {
.procname = "vfs_cache_pressure", .procname = "vfs_cache_pressure",
.data = &sysctl_vfs_cache_pressure, .data = &sysctl_vfs_cache_pressure,
......
...@@ -108,11 +108,6 @@ EXPORT_SYMBOL_GPL(dirty_writeback_interval); ...@@ -108,11 +108,6 @@ EXPORT_SYMBOL_GPL(dirty_writeback_interval);
*/ */
unsigned int dirty_expire_interval = 30 * 100; /* centiseconds */ unsigned int dirty_expire_interval = 30 * 100; /* centiseconds */
/*
* Flag that makes the machine dump writes/reads and block dirtyings.
*/
int block_dump;
/* /*
* Flag that puts the machine in "laptop mode". Doubles as a timeout in jiffies: * Flag that puts the machine in "laptop mode". Doubles as a timeout in jiffies:
* a full sync is triggered after this time elapses without any disk activity. * a full sync is triggered after this time elapses without any disk activity.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment