Commit 3cab2afb authored by Xin Long's avatar Xin Long Committed by David S. Miller

sctp: remove rcu_read_lock from sctp_bind_addr_state

sctp_bind_addr_state() is called either in packet rcv path or
by sctp_copy_local_addr_list(), which are under rcu_read_lock.
So there's no need to call it again in sctp_bind_addr_state().
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6c6fbad6
......@@ -393,24 +393,19 @@ int sctp_bind_addr_state(const struct sctp_bind_addr *bp,
{
struct sctp_sockaddr_entry *laddr;
struct sctp_af *af;
int state = -1;
af = sctp_get_af_specific(addr->sa.sa_family);
if (unlikely(!af))
return state;
return -1;
rcu_read_lock();
list_for_each_entry_rcu(laddr, &bp->address_list, list) {
if (!laddr->valid)
continue;
if (af->cmp_addr(&laddr->a, addr)) {
state = laddr->state;
break;
if (af->cmp_addr(&laddr->a, addr))
return laddr->state;
}
}
rcu_read_unlock();
return state;
return -1;
}
/* Find the first address in the bind address list that is not present in
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment