Commit 3d0ae36e authored by Jiri Slaby's avatar Jiri Slaby Committed by Linus Torvalds

Char: ip2, fix sparse warnings

Unlock two grabbed locks on some paths.
Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ffc41cf8
...@@ -644,12 +644,12 @@ i2QueueCommands(int type, i2ChanStrPtr pCh, int timeout, int nCommands, ...@@ -644,12 +644,12 @@ i2QueueCommands(int type, i2ChanStrPtr pCh, int timeout, int nCommands,
// Normal Expected path - We still hold LOCK // Normal Expected path - We still hold LOCK
break; /* from for()- Enough room: goto proceed */ break; /* from for()- Enough room: goto proceed */
} }
} ip2trace(CHANN, ITRC_QUEUE, 3, 1, totalsize);
WRITE_UNLOCK_IRQRESTORE(lock_var_p, flags);
ip2trace (CHANN, ITRC_QUEUE, 3, 1, totalsize ); } else
ip2trace(CHANN, ITRC_QUEUE, 3, 1, totalsize);
// Prepare to wait for buffers to empty /* Prepare to wait for buffers to empty */
WRITE_UNLOCK_IRQRESTORE(lock_var_p,flags);
serviceOutgoingFifo(pB); // Dump what we got serviceOutgoingFifo(pB); // Dump what we got
if (timeout == 0) { if (timeout == 0) {
...@@ -1830,6 +1830,8 @@ i2StripFifo(i2eBordStrPtr pB) ...@@ -1830,6 +1830,8 @@ i2StripFifo(i2eBordStrPtr pB)
default: // Neither packet? should be impossible default: // Neither packet? should be impossible
ip2trace (ITRC_NO_PORT, ITRC_SFIFO, 5, 1, ip2trace (ITRC_NO_PORT, ITRC_SFIFO, 5, 1,
PTYPE_OF(pB->i2eLeadoffWord) ); PTYPE_OF(pB->i2eLeadoffWord) );
WRITE_UNLOCK_IRQRESTORE(&pB->read_fifo_spinlock,
bflags);
break; break;
} // End of switch on type of packets } // End of switch on type of packets
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment