Commit 3e1a8f10 authored by Fuyun Liang's avatar Fuyun Liang Committed by David S. Miller

net: hns3: fix a bug in hns3_driv_to_eth_caps

The value of link_modes.advertising and the value of link_modes.supported
is initialized to zero every time in for loop in hns3_driv_to_eth_caps().
But we just want to set specified bit for them. Initialization is
unnecessary. This patch fixes it.

Fixes: 496d03e9 (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: default avatarFuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: default avatarLipeng <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b39cabb
...@@ -359,18 +359,13 @@ static void hns3_driv_to_eth_caps(u32 caps, struct ethtool_link_ksettings *cmd, ...@@ -359,18 +359,13 @@ static void hns3_driv_to_eth_caps(u32 caps, struct ethtool_link_ksettings *cmd,
if (!(caps & hns3_lm_map[i].hns3_link_mode)) if (!(caps & hns3_lm_map[i].hns3_link_mode))
continue; continue;
if (is_advertised) { if (is_advertised)
ethtool_link_ksettings_zero_link_mode(cmd,
advertising);
__set_bit(hns3_lm_map[i].ethtool_link_mode, __set_bit(hns3_lm_map[i].ethtool_link_mode,
cmd->link_modes.advertising); cmd->link_modes.advertising);
} else { else
ethtool_link_ksettings_zero_link_mode(cmd,
supported);
__set_bit(hns3_lm_map[i].ethtool_link_mode, __set_bit(hns3_lm_map[i].ethtool_link_mode,
cmd->link_modes.supported); cmd->link_modes.supported);
} }
}
} }
static int hns3_get_sset_count(struct net_device *netdev, int stringset) static int hns3_get_sset_count(struct net_device *netdev, int stringset)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment