Commit 401a582f authored by Ezequiel García's avatar Ezequiel García Committed by Mauro Carvalho Chehab

[media] media: em28xx: Paranoic stack save

This patch saves 255 bytes of stack on usb_probe() by removing
a char array. In some platforms this is represents a substantial save.
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ef3d2dc3
...@@ -3122,7 +3122,6 @@ static int em28xx_usb_probe(struct usb_interface *interface, ...@@ -3122,7 +3122,6 @@ static int em28xx_usb_probe(struct usb_interface *interface,
int i, nr; int i, nr;
const int ifnum = interface->altsetting[0].desc.bInterfaceNumber; const int ifnum = interface->altsetting[0].desc.bInterfaceNumber;
char *speed; char *speed;
char descr[255] = "";
udev = usb_get_dev(interface_to_usbdev(interface)); udev = usb_get_dev(interface_to_usbdev(interface));
...@@ -3227,21 +3226,11 @@ static int em28xx_usb_probe(struct usb_interface *interface, ...@@ -3227,21 +3226,11 @@ static int em28xx_usb_probe(struct usb_interface *interface,
speed = "unknown"; speed = "unknown";
} }
if (udev->manufacturer)
strlcpy(descr, udev->manufacturer, sizeof(descr));
if (udev->product) {
if (*descr)
strlcat(descr, " ", sizeof(descr));
strlcat(descr, udev->product, sizeof(descr));
}
if (*descr)
strlcat(descr, " ", sizeof(descr));
printk(KERN_INFO DRIVER_NAME printk(KERN_INFO DRIVER_NAME
": New device %s@ %s Mbps (%04x:%04x, interface %d, class %d)\n", ": New device %s %s @ %s Mbps "
descr, "(%04x:%04x, interface %d, class %d)\n",
udev->manufacturer ? udev->manufacturer : "",
udev->product ? udev->product : "",
speed, speed,
le16_to_cpu(udev->descriptor.idVendor), le16_to_cpu(udev->descriptor.idVendor),
le16_to_cpu(udev->descriptor.idProduct), le16_to_cpu(udev->descriptor.idProduct),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment