Commit 41598a0b authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman

Staging: hv: mousevsc: Get rid of unnecessary comments

Get rid of unnecessary comments.
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1eadd8c2
...@@ -26,9 +26,6 @@ ...@@ -26,9 +26,6 @@
#include "hyperv.h" #include "hyperv.h"
/*
* Data types
*/
struct hv_input_dev_info { struct hv_input_dev_info {
unsigned int size; unsigned int size;
unsigned short vendor; unsigned short vendor;
...@@ -137,9 +134,6 @@ struct pipe_prt_msg { ...@@ -137,9 +134,6 @@ struct pipe_prt_msg {
char data[1]; char data[1];
}; };
/*
* Data types
*/
struct mousevsc_prt_msg { struct mousevsc_prt_msg {
enum pipe_prot_msg_type type; enum pipe_prot_msg_type type;
u32 size; u32 size;
...@@ -206,11 +200,9 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, ...@@ -206,11 +200,9 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
/* Assume success for now */ /* Assume success for now */
input_device->dev_info_status = 0; input_device->dev_info_status = 0;
/* Save the device attr */
memcpy(&input_device->hid_dev_info, &device_info->hid_dev_info, memcpy(&input_device->hid_dev_info, &device_info->hid_dev_info,
sizeof(struct hv_input_dev_info)); sizeof(struct hv_input_dev_info));
/* Save the hid desc */
desc = &device_info->hid_descriptor; desc = &device_info->hid_descriptor;
WARN_ON(desc->bLength == 0); WARN_ON(desc->bLength == 0);
...@@ -221,7 +213,6 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, ...@@ -221,7 +213,6 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
memcpy(input_device->hid_desc, desc, desc->bLength); memcpy(input_device->hid_desc, desc, desc->bLength);
/* Save the report desc */
input_device->report_desc_size = desc->desc[0].wDescriptorLength; input_device->report_desc_size = desc->desc[0].wDescriptorLength;
if (input_device->report_desc_size == 0) if (input_device->report_desc_size == 0)
goto cleanup; goto cleanup;
...@@ -368,10 +359,6 @@ static void mousevsc_on_channel_callback(void *context) ...@@ -368,10 +359,6 @@ static void mousevsc_on_channel_callback(void *context)
bufferlen = packetSize; bufferlen = packetSize;
} }
} else { } else {
/*
* pr_debug("nothing else to read...");
* reset
*/
if (bufferlen > packetSize) { if (bufferlen > packetSize) {
kfree(buffer); kfree(buffer);
...@@ -388,8 +375,6 @@ static void mousevsc_on_channel_callback(void *context) ...@@ -388,8 +375,6 @@ static void mousevsc_on_channel_callback(void *context)
if (buffer == NULL) { if (buffer == NULL) {
buffer = packet; buffer = packet;
bufferlen = packetSize; bufferlen = packetSize;
/* Try again next time around */
break; break;
} }
} }
...@@ -409,9 +394,6 @@ static int mousevsc_connect_to_vsp(struct hv_device *device) ...@@ -409,9 +394,6 @@ static int mousevsc_connect_to_vsp(struct hv_device *device)
request = &input_dev->protocol_req; request = &input_dev->protocol_req;
/*
* Now, initiate the vsc/vsp initialization protocol on the open channel
*/
memset(request, 0, sizeof(struct mousevsc_prt_msg)); memset(request, 0, sizeof(struct mousevsc_prt_msg));
request->type = PIPE_MESSAGE_DATA; request->type = PIPE_MESSAGE_DATA;
...@@ -525,7 +507,6 @@ static int mousevsc_on_device_add(struct hv_device *device) ...@@ -525,7 +507,6 @@ static int mousevsc_on_device_add(struct hv_device *device)
input_dev->init_complete = false; input_dev->init_complete = false;
/* Open the channel */
ret = vmbus_open(device->channel, ret = vmbus_open(device->channel,
INPUTVSC_SEND_RING_BUFFER_SIZE, INPUTVSC_SEND_RING_BUFFER_SIZE,
INPUTVSC_RECV_RING_BUFFER_SIZE, INPUTVSC_RECV_RING_BUFFER_SIZE,
...@@ -550,7 +531,6 @@ static int mousevsc_on_device_add(struct hv_device *device) ...@@ -550,7 +531,6 @@ static int mousevsc_on_device_add(struct hv_device *device)
} }
/* Send the report desc back up */
/* workaround SA-167 */ /* workaround SA-167 */
if (input_dev->report_desc[14] == 0x25) if (input_dev->report_desc[14] == 0x25)
input_dev->report_desc[14] = 0x29; input_dev->report_desc[14] = 0x29;
...@@ -567,7 +547,6 @@ static int mousevsc_probe(struct hv_device *dev, ...@@ -567,7 +547,6 @@ static int mousevsc_probe(struct hv_device *dev,
const struct hv_vmbus_device_id *dev_id) const struct hv_vmbus_device_id *dev_id)
{ {
/* Call to the vsc driver to add the device */
return mousevsc_on_device_add(dev); return mousevsc_on_device_add(dev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment