Commit 41ccdbfd authored by Daniel Jordan's avatar Daniel Jordan Committed by Herbert Xu

padata: fix uninitialized return value in padata_replace()

According to Geert's report[0],

  kernel/padata.c: warning: 'err' may be used uninitialized in this
    function [-Wuninitialized]:  => 539:2

Warning is seen only with older compilers on certain archs.  The
runtime effect is potentially returning garbage down the stack when
padata's cpumasks are modified before any pcrypt requests have run.

Simplest fix is to initialize err to the success value.

[0] http://lkml.kernel.org/r/20200210135506.11536-1-geert@linux-m68k.orgReported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Fixes: bbefa1dd ("crypto: pcrypt - Avoid deadlock by using per-instance padata queues")
Signed-off-by: default avatarDaniel Jordan <daniel.m.jordan@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent fcdba3c3
...@@ -512,7 +512,7 @@ static int padata_replace_one(struct padata_shell *ps) ...@@ -512,7 +512,7 @@ static int padata_replace_one(struct padata_shell *ps)
static int padata_replace(struct padata_instance *pinst) static int padata_replace(struct padata_instance *pinst)
{ {
struct padata_shell *ps; struct padata_shell *ps;
int err; int err = 0;
pinst->flags |= PADATA_RESET; pinst->flags |= PADATA_RESET;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment