Commit 43553b47 authored by Bart Van Assche's avatar Bart Van Assche Committed by Doug Ledford

IB/rxe: Issue warnings once

It is strongly recommended to report kernel warnings once instead
of every time a condition is hit. Hence change WARN_ON() into
WARN_ON_ONCE() / BUILD_BUG_ON() as appropriate.
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarAndrew Boyer <andrew.boyer@dell.com>
Cc: Moni Shoua <monis@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 32404fb7
......@@ -254,7 +254,7 @@ static inline enum comp_state check_ack(struct rxe_qp *qp,
}
break;
default:
WARN_ON(1);
WARN_ON_ONCE(1);
}
/* Check operation validity. */
......
......@@ -123,7 +123,7 @@ static int rxe_mem_alloc(struct rxe_dev *rxe, struct rxe_mem *mem, int num_buf)
goto err2;
}
WARN_ON(!is_power_of_2(RXE_BUF_PER_MAP));
BUILD_BUG_ON(!is_power_of_2(RXE_BUF_PER_MAP));
mem->map_shift = ilog2(RXE_BUF_PER_MAP);
mem->map_mask = RXE_BUF_PER_MAP - 1;
......@@ -189,7 +189,7 @@ int rxe_mem_init_user(struct rxe_dev *rxe, struct rxe_pd *pd, u64 start,
goto err1;
}
WARN_ON(!is_power_of_2(umem->page_size));
WARN_ON_ONCE(!is_power_of_2(umem->page_size));
mem->page_shift = ilog2(umem->page_size);
mem->page_mask = umem->page_size - 1;
......@@ -375,7 +375,7 @@ int rxe_mem_copy(struct rxe_mem *mem, u64 iova, void *addr, int length,
return 0;
}
WARN_ON(!mem->map);
WARN_ON_ONCE(!mem->map);
err = mem_check_range(mem, iova, length);
if (err) {
......
......@@ -307,7 +307,7 @@ static enum resp_states check_op_valid(struct rxe_qp *qp,
break;
default:
WARN_ON(1);
WARN_ON_ONCE(1);
break;
}
......@@ -495,7 +495,7 @@ static enum resp_states check_rkey(struct rxe_qp *qp,
}
}
WARN_ON(qp->resp.mr);
WARN_ON_ONCE(qp->resp.mr);
qp->resp.mr = mem;
return RESPST_EXECUTE;
......@@ -808,9 +808,10 @@ static enum resp_states execute(struct rxe_qp *qp, struct rxe_pkt_info *pkt)
err = process_atomic(qp, pkt);
if (err)
return err;
} else
} else {
/* Unreachable */
WARN_ON(1);
WARN_ON_ONCE(1);
}
/* We successfully processed this new request. */
qp->resp.msn++;
......@@ -1396,7 +1397,7 @@ int rxe_responder(void *arg)
goto exit;
default:
WARN_ON(1);
WARN_ON_ONCE(1);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment