Commit 44331dfa authored by Mi Jinlong's avatar Mi Jinlong Committed by Greg Kroah-Hartman

nfsd: wrong index used in inner loop

commit 5a02ab7c upstream.

We must not use dummy for index.
After the first index, READ32(dummy) will change dummy!!!!
Signed-off-by: default avatarMi Jinlong <mijinlong@cn.fujitsu.com>
[bfields@redhat.com: Trond points out READ_BUF alone is sufficient.]
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 5166f340
...@@ -1114,7 +1114,7 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, ...@@ -1114,7 +1114,7 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp,
u32 dummy; u32 dummy;
char *machine_name; char *machine_name;
int i, j; int i;
int nr_secflavs; int nr_secflavs;
READ_BUF(16); READ_BUF(16);
...@@ -1187,8 +1187,6 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, ...@@ -1187,8 +1187,6 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp,
READ_BUF(4); READ_BUF(4);
READ32(dummy); READ32(dummy);
READ_BUF(dummy * 4); READ_BUF(dummy * 4);
for (j = 0; j < dummy; ++j)
READ32(dummy);
break; break;
case RPC_AUTH_GSS: case RPC_AUTH_GSS:
dprintk("RPC_AUTH_GSS callback secflavor " dprintk("RPC_AUTH_GSS callback secflavor "
...@@ -1204,7 +1202,6 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, ...@@ -1204,7 +1202,6 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp,
READ_BUF(4); READ_BUF(4);
READ32(dummy); READ32(dummy);
READ_BUF(dummy); READ_BUF(dummy);
p += XDR_QUADLEN(dummy);
break; break;
default: default:
dprintk("Illegal callback secflavor\n"); dprintk("Illegal callback secflavor\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment