Commit 46833a86 authored by Mike Pecovnik's avatar Mike Pecovnik Committed by David S. Miller

net: Fix permission check in netlink_connect()

netlink_sendmsg() was changed to prevent non-root processes from sending
messages with dst_pid != 0.
netlink_connect() however still only checks if nladdr->nl_groups is set.
This patch modifies netlink_connect() to check for the same condition.
Signed-off-by: default avatarMike Pecovnik <mike.pecovnik@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 687d705c
...@@ -1489,8 +1489,8 @@ static int netlink_connect(struct socket *sock, struct sockaddr *addr, ...@@ -1489,8 +1489,8 @@ static int netlink_connect(struct socket *sock, struct sockaddr *addr,
if (addr->sa_family != AF_NETLINK) if (addr->sa_family != AF_NETLINK)
return -EINVAL; return -EINVAL;
/* Only superuser is allowed to send multicasts */ if ((nladdr->nl_groups || nladdr->nl_pid) &&
if (nladdr->nl_groups && !netlink_capable(sock, NL_CFG_F_NONROOT_SEND)) !netlink_capable(sock, NL_CFG_F_NONROOT_SEND))
return -EPERM; return -EPERM;
if (!nlk->portid) if (!nlk->portid)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment