Commit 473af09b authored by Sam Bobroff's avatar Sam Bobroff Committed by Michael Ellerman

powerpc/eeh: Fix use of EEH_PE_KEEP on wrong field

eeh_add_to_parent_pe() sometimes removes the EEH_PE_KEEP flag, but it
incorrectly removes it from pe->type, instead of pe->state.

However, rather than clearing it from the correct field, remove it.
Inspection of the code shows that it can't ever have had any effect
(even if it had been cleared from the correct field), because the
field is never tested after it is cleared by the statement in
question.

The clear statement was added by commit 807a827d ("powerpc/eeh:
Keep PE during hotplug"), but it didn't explain why it was necessary.
Signed-off-by: default avatarSam Bobroff <sbobroff@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent bcbe3730
...@@ -379,7 +379,7 @@ int eeh_add_to_parent_pe(struct eeh_dev *edev) ...@@ -379,7 +379,7 @@ int eeh_add_to_parent_pe(struct eeh_dev *edev)
while (parent) { while (parent) {
if (!(parent->type & EEH_PE_INVALID)) if (!(parent->type & EEH_PE_INVALID))
break; break;
parent->type &= ~(EEH_PE_INVALID | EEH_PE_KEEP); parent->type &= ~EEH_PE_INVALID;
parent = parent->parent; parent = parent->parent;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment