Commit 47bd37f9 authored by Rob Clark's avatar Rob Clark

drm/msm/adreno: Move adreno info to config

Let's just stash it in adreno_platform_config rather than looking it up
in N different places.
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/549777/
parent 8825f596
...@@ -2316,7 +2316,6 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) ...@@ -2316,7 +2316,6 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
struct msm_drm_private *priv = dev->dev_private; struct msm_drm_private *priv = dev->dev_private;
struct platform_device *pdev = priv->gpu_pdev; struct platform_device *pdev = priv->gpu_pdev;
struct adreno_platform_config *config = pdev->dev.platform_data; struct adreno_platform_config *config = pdev->dev.platform_data;
const struct adreno_info *info;
struct device_node *node; struct device_node *node;
struct a6xx_gpu *a6xx_gpu; struct a6xx_gpu *a6xx_gpu;
struct adreno_gpu *adreno_gpu; struct adreno_gpu *adreno_gpu;
...@@ -2341,20 +2340,12 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) ...@@ -2341,20 +2340,12 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
adreno_gpu->gmu_is_wrapper = of_device_is_compatible(node, "qcom,adreno-gmu-wrapper"); adreno_gpu->gmu_is_wrapper = of_device_is_compatible(node, "qcom,adreno-gmu-wrapper");
/* adreno_gpu->base.hw_apriv =
* We need to know the platform type before calling into adreno_gpu_init !!(config->info->quirks & ADRENO_QUIRK_HAS_HW_APRIV);
* so that the hw_apriv flag can be correctly set. Snoop into the info
* and grab the revision number
*/
info = adreno_info(config->rev);
if (!info)
return ERR_PTR(-EINVAL);
adreno_gpu->base.hw_apriv = !!(info->quirks & ADRENO_QUIRK_HAS_HW_APRIV);
a6xx_llc_slices_init(pdev, a6xx_gpu); a6xx_llc_slices_init(pdev, a6xx_gpu);
ret = a6xx_set_supported_hw(&pdev->dev, info); ret = a6xx_set_supported_hw(&pdev->dev, config->info);
if (ret) { if (ret) {
a6xx_destroy(&(a6xx_gpu->base.base)); a6xx_destroy(&(a6xx_gpu->base.base));
return ERR_PTR(ret); return ERR_PTR(ret);
......
...@@ -508,7 +508,7 @@ bool adreno_cmp_rev(struct adreno_rev rev1, struct adreno_rev rev2) ...@@ -508,7 +508,7 @@ bool adreno_cmp_rev(struct adreno_rev rev1, struct adreno_rev rev2)
_rev_match(rev1.patchid, rev2.patchid); _rev_match(rev1.patchid, rev2.patchid);
} }
const struct adreno_info *adreno_info(struct adreno_rev rev) static const struct adreno_info *adreno_info(struct adreno_rev rev)
{ {
int i; int i;
...@@ -659,13 +659,14 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) ...@@ -659,13 +659,14 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
priv->gpu_pdev = to_platform_device(dev); priv->gpu_pdev = to_platform_device(dev);
info = adreno_info(config.rev); info = adreno_info(config.rev);
if (!info) { if (!info) {
dev_warn(drm->dev, "Unknown GPU revision: %"ADRENO_CHIPID_FMT"\n", dev_warn(drm->dev, "Unknown GPU revision: %"ADRENO_CHIPID_FMT"\n",
ADRENO_CHIPID_ARGS(config.rev)); ADRENO_CHIPID_ARGS(config.rev));
return -ENXIO; return -ENXIO;
} }
config.info = info;
DBG("Found GPU: %"ADRENO_CHIPID_FMT, ADRENO_CHIPID_ARGS(config.rev)); DBG("Found GPU: %"ADRENO_CHIPID_FMT, ADRENO_CHIPID_ARGS(config.rev));
priv->is_a2xx = info->family < ADRENO_3XX; priv->is_a2xx = info->family < ADRENO_3XX;
......
...@@ -1079,7 +1079,7 @@ int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev, ...@@ -1079,7 +1079,7 @@ int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev,
int ret; int ret;
adreno_gpu->funcs = funcs; adreno_gpu->funcs = funcs;
adreno_gpu->info = adreno_info(config->rev); adreno_gpu->info = config->info;
adreno_gpu->rev = *rev; adreno_gpu->rev = *rev;
/* Only handle the core clock when GMU is not in use (or is absent). */ /* Only handle the core clock when GMU is not in use (or is absent). */
......
...@@ -130,8 +130,6 @@ struct adreno_info { ...@@ -130,8 +130,6 @@ struct adreno_info {
*/ */
#define ADRENO_SPEEDBINS(tbl...) (struct adreno_speedbin[]) { tbl {SHRT_MAX, 0} } #define ADRENO_SPEEDBINS(tbl...) (struct adreno_speedbin[]) { tbl {SHRT_MAX, 0} }
const struct adreno_info *adreno_info(struct adreno_rev rev);
struct adreno_gpu { struct adreno_gpu {
struct msm_gpu base; struct msm_gpu base;
struct adreno_rev rev; struct adreno_rev rev;
...@@ -185,6 +183,7 @@ struct adreno_ocmem { ...@@ -185,6 +183,7 @@ struct adreno_ocmem {
/* platform config data (ie. from DT, or pdata) */ /* platform config data (ie. from DT, or pdata) */
struct adreno_platform_config { struct adreno_platform_config {
struct adreno_rev rev; struct adreno_rev rev;
const struct adreno_info *info;
}; };
#define ADRENO_IDLE_TIMEOUT msecs_to_jiffies(1000) #define ADRENO_IDLE_TIMEOUT msecs_to_jiffies(1000)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment