Commit 4b1524ce authored by Roland Vossen's avatar Roland Vossen Committed by Greg Kroah-Hartman

staging: brcm80211: simpler string handling in brcmf_c_pktfilter_offload_set()

Replaced two functions with strcpy().
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 564f2e7d
...@@ -958,13 +958,7 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg) ...@@ -958,13 +958,7 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg)
goto fail; goto fail;
} }
memcpy(arg_save, arg, strlen(arg) + 1); strcpy(arg_save, arg);
if (strlen(arg) > PKTFILTER_BUF_SIZE) {
BRCMF_ERROR(("Not enough buffer %d < %d\n", (int)strlen(arg),
(int)sizeof(buf)));
goto fail;
}
argv[i] = strsep(&arg_save, " "); argv[i] = strsep(&arg_save, " ");
while (argv[i++]) while (argv[i++])
...@@ -977,9 +971,8 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg) ...@@ -977,9 +971,8 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg)
} }
str = "pkt_filter_add"; str = "pkt_filter_add";
strcpy(buf, str);
str_len = strlen(str); str_len = strlen(str);
strncpy(buf, str, str_len);
buf[str_len] = '\0';
buf_len = str_len + 1; buf_len = str_len + 1;
pkt_filterp = (struct brcmf_pkt_filter *) (buf + str_len + 1); pkt_filterp = (struct brcmf_pkt_filter *) (buf + str_len + 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment