Commit 4d25e977 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

media: imx-pxp: Use non-threaded IRQ

There's no need to use threaded IRQs with the PXP, as the interrupt
handler doesn't need to sleep and doesn't perform any time-consuming
operation. Switch to regular IRQ handler.

This fixes lockups of the PXP noticed on i.MX7, where the PXP would stop
generating interrupts after a variable number of frames (from a few
dozens to a few hundreds). The root cause is however unknown.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMichael Tretter <m.tretter@pengutronix.de>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 36e5c362
...@@ -1798,8 +1798,8 @@ static int pxp_probe(struct platform_device *pdev) ...@@ -1798,8 +1798,8 @@ static int pxp_probe(struct platform_device *pdev)
spin_lock_init(&dev->irqlock); spin_lock_init(&dev->irqlock);
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, pxp_irq_handler, ret = devm_request_irq(&pdev->dev, irq, pxp_irq_handler, 0,
IRQF_ONESHOT, dev_name(&pdev->dev), dev); dev_name(&pdev->dev), dev);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "Failed to request irq: %d\n", ret); dev_err(&pdev->dev, "Failed to request irq: %d\n", ret);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment