Commit 4e0ecb77 authored by Eric Dumazet's avatar Eric Dumazet Committed by Sasha Levin

dccp/tcp: do not inherit mc_list from parent

[ Upstream commit 657831ff ]

syzkaller found a way to trigger double frees from ip_mc_drop_socket()

It turns out that leave a copy of parent mc_list at accept() time,
which is very bad.

Very similar to commit 8b485ce6 ("tcp: do not inherit
fastopen_req from parent")

Initial report from Pray3r, completed by Andrey one.
Thanks a lot to them !
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarPray3r <pray3r.z@gmail.com>
Reported-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Tested-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
parent 4bd4cfc5
...@@ -719,6 +719,8 @@ struct sock *inet_csk_clone_lock(const struct sock *sk, ...@@ -719,6 +719,8 @@ struct sock *inet_csk_clone_lock(const struct sock *sk,
inet_sk(newsk)->inet_sport = htons(inet_rsk(req)->ir_num); inet_sk(newsk)->inet_sport = htons(inet_rsk(req)->ir_num);
newsk->sk_write_space = sk_stream_write_space; newsk->sk_write_space = sk_stream_write_space;
inet_sk(newsk)->mc_list = NULL;
newsk->sk_mark = inet_rsk(req)->ir_mark; newsk->sk_mark = inet_rsk(req)->ir_mark;
atomic64_set(&newsk->sk_cookie, atomic64_set(&newsk->sk_cookie,
atomic64_read(&inet_rsk(req)->ir_cookie)); atomic64_read(&inet_rsk(req)->ir_cookie));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment