Commit 4edd7dc8 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Bjorn Helgaas

PCI: endpoint: Rename core_init() callback in 'struct pci_epc_event_ops' to epc_init()

core_init() callback is used to notify the EPC initialization event to the
EPF drivers. The 'core' prefix was used indicate that the controller IP
core has completed initialization. But it serves no purpose as the EPF
driver will only care about the EPC initialization as a whole and there is
no real benefit to distinguish the IP core part.

Rename the core_init() callback in 'struct pci_epc_event_ops' to epc_init()
to make it more clear.

Link: https://lore.kernel.org/linux-pci/20240430-pci-epf-rework-v4-2-22832d0d456f@linaro.orgTested-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
parent 6859e4f2
...@@ -716,7 +716,7 @@ static void pci_epf_mhi_dma_deinit(struct pci_epf_mhi *epf_mhi) ...@@ -716,7 +716,7 @@ static void pci_epf_mhi_dma_deinit(struct pci_epf_mhi *epf_mhi)
epf_mhi->dma_chan_rx = NULL; epf_mhi->dma_chan_rx = NULL;
} }
static int pci_epf_mhi_core_init(struct pci_epf *epf) static int pci_epf_mhi_epc_init(struct pci_epf *epf)
{ {
struct pci_epf_mhi *epf_mhi = epf_get_drvdata(epf); struct pci_epf_mhi *epf_mhi = epf_get_drvdata(epf);
const struct pci_epf_mhi_ep_info *info = epf_mhi->info; const struct pci_epf_mhi_ep_info *info = epf_mhi->info;
...@@ -897,7 +897,7 @@ static void pci_epf_mhi_unbind(struct pci_epf *epf) ...@@ -897,7 +897,7 @@ static void pci_epf_mhi_unbind(struct pci_epf *epf)
} }
static const struct pci_epc_event_ops pci_epf_mhi_event_ops = { static const struct pci_epc_event_ops pci_epf_mhi_event_ops = {
.core_init = pci_epf_mhi_core_init, .epc_init = pci_epf_mhi_epc_init,
.link_up = pci_epf_mhi_link_up, .link_up = pci_epf_mhi_link_up,
.link_down = pci_epf_mhi_link_down, .link_down = pci_epf_mhi_link_down,
.bme = pci_epf_mhi_bme, .bme = pci_epf_mhi_bme,
......
...@@ -731,7 +731,7 @@ static int pci_epf_test_set_bar(struct pci_epf *epf) ...@@ -731,7 +731,7 @@ static int pci_epf_test_set_bar(struct pci_epf *epf)
return 0; return 0;
} }
static int pci_epf_test_core_init(struct pci_epf *epf) static int pci_epf_test_epc_init(struct pci_epf *epf)
{ {
struct pci_epf_test *epf_test = epf_get_drvdata(epf); struct pci_epf_test *epf_test = epf_get_drvdata(epf);
struct pci_epf_header *header = epf->header; struct pci_epf_header *header = epf->header;
...@@ -791,7 +791,7 @@ static int pci_epf_test_link_up(struct pci_epf *epf) ...@@ -791,7 +791,7 @@ static int pci_epf_test_link_up(struct pci_epf *epf)
} }
static const struct pci_epc_event_ops pci_epf_test_event_ops = { static const struct pci_epc_event_ops pci_epf_test_event_ops = {
.core_init = pci_epf_test_core_init, .epc_init = pci_epf_test_epc_init,
.link_up = pci_epf_test_link_up, .link_up = pci_epf_test_link_up,
}; };
......
...@@ -727,9 +727,9 @@ void pci_epc_linkdown(struct pci_epc *epc) ...@@ -727,9 +727,9 @@ void pci_epc_linkdown(struct pci_epc *epc)
EXPORT_SYMBOL_GPL(pci_epc_linkdown); EXPORT_SYMBOL_GPL(pci_epc_linkdown);
/** /**
* pci_epc_init_notify() - Notify the EPF device that EPC device's core * pci_epc_init_notify() - Notify the EPF device that EPC device initialization
* initialization is completed. * is completed.
* @epc: the EPC device whose core initialization is completed * @epc: the EPC device whose initialization is completed
* *
* Invoke to Notify the EPF device that the EPC device's initialization * Invoke to Notify the EPF device that the EPC device's initialization
* is completed. * is completed.
...@@ -744,8 +744,8 @@ void pci_epc_init_notify(struct pci_epc *epc) ...@@ -744,8 +744,8 @@ void pci_epc_init_notify(struct pci_epc *epc)
mutex_lock(&epc->list_lock); mutex_lock(&epc->list_lock);
list_for_each_entry(epf, &epc->pci_epf, list) { list_for_each_entry(epf, &epc->pci_epf, list) {
mutex_lock(&epf->lock); mutex_lock(&epf->lock);
if (epf->event_ops && epf->event_ops->core_init) if (epf->event_ops && epf->event_ops->epc_init)
epf->event_ops->core_init(epf); epf->event_ops->epc_init(epf);
mutex_unlock(&epf->lock); mutex_unlock(&epf->lock);
} }
epc->init_complete = true; epc->init_complete = true;
...@@ -756,7 +756,7 @@ EXPORT_SYMBOL_GPL(pci_epc_init_notify); ...@@ -756,7 +756,7 @@ EXPORT_SYMBOL_GPL(pci_epc_init_notify);
/** /**
* pci_epc_notify_pending_init() - Notify the pending EPC device initialization * pci_epc_notify_pending_init() - Notify the pending EPC device initialization
* complete to the EPF device * complete to the EPF device
* @epc: the EPC device whose core initialization is pending to be notified * @epc: the EPC device whose initialization is pending to be notified
* @epf: the EPF device to be notified * @epf: the EPF device to be notified
* *
* Invoke to notify the pending EPC device initialization complete to the EPF * Invoke to notify the pending EPC device initialization complete to the EPF
...@@ -767,8 +767,8 @@ void pci_epc_notify_pending_init(struct pci_epc *epc, struct pci_epf *epf) ...@@ -767,8 +767,8 @@ void pci_epc_notify_pending_init(struct pci_epc *epc, struct pci_epf *epf)
{ {
if (epc->init_complete) { if (epc->init_complete) {
mutex_lock(&epf->lock); mutex_lock(&epf->lock);
if (epf->event_ops && epf->event_ops->core_init) if (epf->event_ops && epf->event_ops->epc_init)
epf->event_ops->core_init(epf); epf->event_ops->epc_init(epf);
mutex_unlock(&epf->lock); mutex_unlock(&epf->lock);
} }
} }
......
...@@ -70,13 +70,13 @@ struct pci_epf_ops { ...@@ -70,13 +70,13 @@ struct pci_epf_ops {
/** /**
* struct pci_epc_event_ops - Callbacks for capturing the EPC events * struct pci_epc_event_ops - Callbacks for capturing the EPC events
* @core_init: Callback for the EPC initialization complete event * @epc_init: Callback for the EPC initialization complete event
* @link_up: Callback for the EPC link up event * @link_up: Callback for the EPC link up event
* @link_down: Callback for the EPC link down event * @link_down: Callback for the EPC link down event
* @bme: Callback for the EPC BME (Bus Master Enable) event * @bme: Callback for the EPC BME (Bus Master Enable) event
*/ */
struct pci_epc_event_ops { struct pci_epc_event_ops {
int (*core_init)(struct pci_epf *epf); int (*epc_init)(struct pci_epf *epf);
int (*link_up)(struct pci_epf *epf); int (*link_up)(struct pci_epf *epf);
int (*link_down)(struct pci_epf *epf); int (*link_down)(struct pci_epf *epf);
int (*bme)(struct pci_epf *epf); int (*bme)(struct pci_epf *epf);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment