Commit 4eec7faf authored by Guenter Roeck's avatar Guenter Roeck Committed by Linus Torvalds

fs: ntfs: Limit NTFS_RW to page sizes smaller than 64k

NTFS_RW code allocates page size dependent arrays on the stack. This
results in build failures if the page size is 64k or larger.

  fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
  fs/ntfs/aops.c:1311:1: error:
	the frame size of 2240 bytes is larger than 2048 bytes

Since commit f22969a6 ("powerpc/64s: Default to 64K pages for 64 bit
book3s") this affects ppc:allmodconfig builds, but other architectures
supporting page sizes of 64k or larger are also affected.

Increasing the maximum frame size for affected architectures just to
silence this error does not really help.  The frame size would have to
be set to a really large value for 256k pages.  Also, a large frame size
could potentially result in stack overruns in this code and elsewhere
and is therefore not desirable.  Make NTFS_RW dependent on page sizes
smaller than 64k instead.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Cc: Anton Altaparmakov <anton@tuxera.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1f0e290c
...@@ -52,6 +52,7 @@ config NTFS_DEBUG ...@@ -52,6 +52,7 @@ config NTFS_DEBUG
config NTFS_RW config NTFS_RW
bool "NTFS write support" bool "NTFS write support"
depends on NTFS_FS depends on NTFS_FS
depends on PAGE_SIZE_LESS_THAN_64KB
help help
This enables the partial, but safe, write support in the NTFS driver. This enables the partial, but safe, write support in the NTFS driver.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment