Commit 4f9adc8f authored by Todd Kjos's avatar Todd Kjos Committed by Greg Kroah-Hartman

binder: fix incorrect cmd to binder_stat_br

commit 26549d17 ("binder: guarantee txn complete / errors delivered
in-order") passed the locally declared and undefined cmd
to binder_stat_br() which results in a bogus cmd field in a trace
event and BR stats are incremented incorrectly.

Change to use e->cmd which has been initialized.
Signed-off-by: default avatarTodd Kjos <tkjos@google.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 26549d17 ("binder: guarantee txn complete / errors delivered in-order")
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 22eb9476
...@@ -3619,7 +3619,7 @@ static int binder_thread_read(struct binder_proc *proc, ...@@ -3619,7 +3619,7 @@ static int binder_thread_read(struct binder_proc *proc,
e->cmd = BR_OK; e->cmd = BR_OK;
ptr += sizeof(uint32_t); ptr += sizeof(uint32_t);
binder_stat_br(proc, thread, cmd); binder_stat_br(proc, thread, e->cmd);
} break; } break;
case BINDER_WORK_TRANSACTION_COMPLETE: { case BINDER_WORK_TRANSACTION_COMPLETE: {
binder_inner_proc_unlock(proc); binder_inner_proc_unlock(proc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment