Commit 4fe20d62 authored by Zhang Yiqun's avatar Zhang Yiqun Committed by Takashi Iwai

ALSA: hda: remove redundant variable in snd_hdac_stream_start()

This 2nd variables are all set as true in treewide. So I think
it can be removed for easy understanding.
Signed-off-by: default avatarZhang Yiqun <zhangyiqun@phytium.com.cn>
Acked-by: default avatarMark Brown <broonie@kernel.org>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230209121723.14328-1-zhangyiqun@phytium.com.cnSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 86bdfa26
...@@ -575,7 +575,7 @@ void snd_hdac_stream_cleanup(struct hdac_stream *azx_dev); ...@@ -575,7 +575,7 @@ void snd_hdac_stream_cleanup(struct hdac_stream *azx_dev);
int snd_hdac_stream_setup_periods(struct hdac_stream *azx_dev); int snd_hdac_stream_setup_periods(struct hdac_stream *azx_dev);
int snd_hdac_stream_set_params(struct hdac_stream *azx_dev, int snd_hdac_stream_set_params(struct hdac_stream *azx_dev,
unsigned int format_val); unsigned int format_val);
void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start); void snd_hdac_stream_start(struct hdac_stream *azx_dev);
void snd_hdac_stream_stop(struct hdac_stream *azx_dev); void snd_hdac_stream_stop(struct hdac_stream *azx_dev);
void snd_hdac_stop_streams(struct hdac_bus *bus); void snd_hdac_stop_streams(struct hdac_bus *bus);
void snd_hdac_stop_streams_and_chip(struct hdac_bus *bus); void snd_hdac_stop_streams_and_chip(struct hdac_bus *bus);
......
...@@ -124,11 +124,10 @@ EXPORT_SYMBOL_GPL(snd_hdac_stream_init); ...@@ -124,11 +124,10 @@ EXPORT_SYMBOL_GPL(snd_hdac_stream_init);
/** /**
* snd_hdac_stream_start - start a stream * snd_hdac_stream_start - start a stream
* @azx_dev: HD-audio core stream to start * @azx_dev: HD-audio core stream to start
* @fresh_start: false = wallclock timestamp relative to period wallclock
* *
* Start a stream, set start_wallclk and set the running flag. * Start a stream, set start_wallclk and set the running flag.
*/ */
void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start) void snd_hdac_stream_start(struct hdac_stream *azx_dev)
{ {
struct hdac_bus *bus = azx_dev->bus; struct hdac_bus *bus = azx_dev->bus;
int stripe_ctl; int stripe_ctl;
...@@ -136,8 +135,6 @@ void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start) ...@@ -136,8 +135,6 @@ void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start)
trace_snd_hdac_stream_start(bus, azx_dev); trace_snd_hdac_stream_start(bus, azx_dev);
azx_dev->start_wallclk = snd_hdac_chip_readl(bus, WALLCLK); azx_dev->start_wallclk = snd_hdac_chip_readl(bus, WALLCLK);
if (!fresh_start)
azx_dev->start_wallclk -= azx_dev->period_wallclk;
/* enable SIE */ /* enable SIE */
snd_hdac_chip_updatel(bus, INTCTL, snd_hdac_chip_updatel(bus, INTCTL,
...@@ -966,7 +963,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_dsp_prepare); ...@@ -966,7 +963,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_dsp_prepare);
void snd_hdac_dsp_trigger(struct hdac_stream *azx_dev, bool start) void snd_hdac_dsp_trigger(struct hdac_stream *azx_dev, bool start)
{ {
if (start) if (start)
snd_hdac_stream_start(azx_dev, true); snd_hdac_stream_start(azx_dev);
else else
snd_hdac_stream_stop(azx_dev); snd_hdac_stream_stop(azx_dev);
} }
......
...@@ -257,7 +257,7 @@ static int azx_pcm_trigger(struct snd_pcm_substream *substream, int cmd) ...@@ -257,7 +257,7 @@ static int azx_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
azx_dev = get_azx_dev(s); azx_dev = get_azx_dev(s);
if (start) { if (start) {
azx_dev->insufficient = 1; azx_dev->insufficient = 1;
snd_hdac_stream_start(azx_stream(azx_dev), true); snd_hdac_stream_start(azx_stream(azx_dev));
} else { } else {
snd_hdac_stream_stop(azx_stream(azx_dev)); snd_hdac_stream_stop(azx_stream(azx_dev));
} }
......
...@@ -647,7 +647,7 @@ static int avs_dai_fe_trigger(struct snd_pcm_substream *substream, int cmd, stru ...@@ -647,7 +647,7 @@ static int avs_dai_fe_trigger(struct snd_pcm_substream *substream, int cmd, stru
case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
spin_lock_irqsave(&bus->reg_lock, flags); spin_lock_irqsave(&bus->reg_lock, flags);
snd_hdac_stream_start(hdac_stream(host_stream), true); snd_hdac_stream_start(hdac_stream(host_stream));
spin_unlock_irqrestore(&bus->reg_lock, flags); spin_unlock_irqrestore(&bus->reg_lock, flags);
/* Timeout on DRSM poll shall not stop the resume so ignore the result. */ /* Timeout on DRSM poll shall not stop the resume so ignore the result. */
......
...@@ -190,7 +190,7 @@ static int avs_probe_compr_trigger(struct snd_compr_stream *cstream, int cmd, ...@@ -190,7 +190,7 @@ static int avs_probe_compr_trigger(struct snd_compr_stream *cstream, int cmd,
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
case SNDRV_PCM_TRIGGER_RESUME: case SNDRV_PCM_TRIGGER_RESUME:
spin_lock_irqsave(&bus->reg_lock, cookie); spin_lock_irqsave(&bus->reg_lock, cookie);
snd_hdac_stream_start(hdac_stream(host_stream), true); snd_hdac_stream_start(hdac_stream(host_stream));
spin_unlock_irqrestore(&bus->reg_lock, cookie); spin_unlock_irqrestore(&bus->reg_lock, cookie);
break; break;
......
...@@ -449,7 +449,7 @@ static int skl_decoupled_trigger(struct snd_pcm_substream *substream, ...@@ -449,7 +449,7 @@ static int skl_decoupled_trigger(struct snd_pcm_substream *substream,
spin_lock_irqsave(&bus->reg_lock, cookie); spin_lock_irqsave(&bus->reg_lock, cookie);
if (start) { if (start) {
snd_hdac_stream_start(hdac_stream(stream), true); snd_hdac_stream_start(hdac_stream(stream));
snd_hdac_stream_timecounter_init(hstr, 0); snd_hdac_stream_timecounter_init(hstr, 0);
} else { } else {
snd_hdac_stream_stop(hdac_stream(stream)); snd_hdac_stream_stop(hdac_stream(stream));
...@@ -1134,7 +1134,7 @@ static int skl_coupled_trigger(struct snd_pcm_substream *substream, ...@@ -1134,7 +1134,7 @@ static int skl_coupled_trigger(struct snd_pcm_substream *substream,
continue; continue;
stream = get_hdac_ext_stream(s); stream = get_hdac_ext_stream(s);
if (start) if (start)
snd_hdac_stream_start(hdac_stream(stream), true); snd_hdac_stream_start(hdac_stream(stream));
else else
snd_hdac_stream_stop(hdac_stream(stream)); snd_hdac_stream_stop(hdac_stream(stream));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment