Commit 4fe8590a authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter

drm/i915: Use adjusted_mode appropriately when computing watermarks

Currently most of the watermark code looks at crtc->mode which is the
user requested mode. The only piece of information there that is
relevant is hdisplay, the rest must come from adjusted_mode. Convert
all of the code to use requested_mode and adjusted_mode from
pipe config appropriately.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent ef644fda
...@@ -1110,7 +1110,7 @@ static void pineview_update_wm(struct drm_crtc *unused_crtc) ...@@ -1110,7 +1110,7 @@ static void pineview_update_wm(struct drm_crtc *unused_crtc)
crtc = single_enabled_crtc(dev); crtc = single_enabled_crtc(dev);
if (crtc) { if (crtc) {
int clock = crtc->mode.clock; int clock = to_intel_crtc(crtc)->config.adjusted_mode.clock;
int pixel_size = crtc->fb->bits_per_pixel / 8; int pixel_size = crtc->fb->bits_per_pixel / 8;
/* Display SR */ /* Display SR */
...@@ -1171,6 +1171,7 @@ static bool g4x_compute_wm0(struct drm_device *dev, ...@@ -1171,6 +1171,7 @@ static bool g4x_compute_wm0(struct drm_device *dev,
int *cursor_wm) int *cursor_wm)
{ {
struct drm_crtc *crtc; struct drm_crtc *crtc;
const struct drm_display_mode *adjusted_mode;
int htotal, hdisplay, clock, pixel_size; int htotal, hdisplay, clock, pixel_size;
int line_time_us, line_count; int line_time_us, line_count;
int entries, tlb_miss; int entries, tlb_miss;
...@@ -1182,9 +1183,10 @@ static bool g4x_compute_wm0(struct drm_device *dev, ...@@ -1182,9 +1183,10 @@ static bool g4x_compute_wm0(struct drm_device *dev,
return false; return false;
} }
htotal = crtc->mode.htotal; adjusted_mode = &to_intel_crtc(crtc)->config.adjusted_mode;
hdisplay = crtc->mode.hdisplay; clock = adjusted_mode->clock;
clock = crtc->mode.clock; htotal = adjusted_mode->htotal;
hdisplay = to_intel_crtc(crtc)->config.requested_mode.hdisplay;
pixel_size = crtc->fb->bits_per_pixel / 8; pixel_size = crtc->fb->bits_per_pixel / 8;
/* Use the small buffer method to calculate plane watermark */ /* Use the small buffer method to calculate plane watermark */
...@@ -1255,6 +1257,7 @@ static bool g4x_compute_srwm(struct drm_device *dev, ...@@ -1255,6 +1257,7 @@ static bool g4x_compute_srwm(struct drm_device *dev,
int *display_wm, int *cursor_wm) int *display_wm, int *cursor_wm)
{ {
struct drm_crtc *crtc; struct drm_crtc *crtc;
const struct drm_display_mode *adjusted_mode;
int hdisplay, htotal, pixel_size, clock; int hdisplay, htotal, pixel_size, clock;
unsigned long line_time_us; unsigned long line_time_us;
int line_count, line_size; int line_count, line_size;
...@@ -1267,9 +1270,10 @@ static bool g4x_compute_srwm(struct drm_device *dev, ...@@ -1267,9 +1270,10 @@ static bool g4x_compute_srwm(struct drm_device *dev,
} }
crtc = intel_get_crtc_for_plane(dev, plane); crtc = intel_get_crtc_for_plane(dev, plane);
hdisplay = crtc->mode.hdisplay; adjusted_mode = &to_intel_crtc(crtc)->config.adjusted_mode;
htotal = crtc->mode.htotal; clock = adjusted_mode->clock;
clock = crtc->mode.clock; htotal = adjusted_mode->htotal;
hdisplay = to_intel_crtc(crtc)->config.requested_mode.hdisplay;
pixel_size = crtc->fb->bits_per_pixel / 8; pixel_size = crtc->fb->bits_per_pixel / 8;
line_time_us = (htotal * 1000) / clock; line_time_us = (htotal * 1000) / clock;
...@@ -1308,7 +1312,7 @@ static bool vlv_compute_drain_latency(struct drm_device *dev, ...@@ -1308,7 +1312,7 @@ static bool vlv_compute_drain_latency(struct drm_device *dev,
if (!intel_crtc_active(crtc)) if (!intel_crtc_active(crtc))
return false; return false;
clock = crtc->mode.clock; /* VESA DOT Clock */ clock = to_intel_crtc(crtc)->config.adjusted_mode.clock;
pixel_size = crtc->fb->bits_per_pixel / 8; /* BPP */ pixel_size = crtc->fb->bits_per_pixel / 8; /* BPP */
entries = (clock / 1000) * pixel_size; entries = (clock / 1000) * pixel_size;
...@@ -1496,9 +1500,11 @@ static void i965_update_wm(struct drm_crtc *unused_crtc) ...@@ -1496,9 +1500,11 @@ static void i965_update_wm(struct drm_crtc *unused_crtc)
if (crtc) { if (crtc) {
/* self-refresh has much higher latency */ /* self-refresh has much higher latency */
static const int sr_latency_ns = 12000; static const int sr_latency_ns = 12000;
int clock = crtc->mode.clock; const struct drm_display_mode *adjusted_mode =
int htotal = crtc->mode.htotal; &to_intel_crtc(crtc)->config.adjusted_mode;
int hdisplay = crtc->mode.hdisplay; int clock = adjusted_mode->clock;
int htotal = adjusted_mode->htotal;
int hdisplay = to_intel_crtc(crtc)->config.requested_mode.hdisplay;
int pixel_size = crtc->fb->bits_per_pixel / 8; int pixel_size = crtc->fb->bits_per_pixel / 8;
unsigned long line_time_us; unsigned long line_time_us;
int entries; int entries;
...@@ -1575,7 +1581,7 @@ static void i9xx_update_wm(struct drm_crtc *unused_crtc) ...@@ -1575,7 +1581,7 @@ static void i9xx_update_wm(struct drm_crtc *unused_crtc)
if (IS_GEN2(dev)) if (IS_GEN2(dev))
cpp = 4; cpp = 4;
planea_wm = intel_calculate_wm(crtc->mode.clock, planea_wm = intel_calculate_wm(to_intel_crtc(crtc)->config.adjusted_mode.clock,
wm_info, fifo_size, cpp, wm_info, fifo_size, cpp,
latency_ns); latency_ns);
enabled = crtc; enabled = crtc;
...@@ -1589,7 +1595,7 @@ static void i9xx_update_wm(struct drm_crtc *unused_crtc) ...@@ -1589,7 +1595,7 @@ static void i9xx_update_wm(struct drm_crtc *unused_crtc)
if (IS_GEN2(dev)) if (IS_GEN2(dev))
cpp = 4; cpp = 4;
planeb_wm = intel_calculate_wm(crtc->mode.clock, planeb_wm = intel_calculate_wm(to_intel_crtc(crtc)->config.adjusted_mode.clock,
wm_info, fifo_size, cpp, wm_info, fifo_size, cpp,
latency_ns); latency_ns);
if (enabled == NULL) if (enabled == NULL)
...@@ -1616,9 +1622,11 @@ static void i9xx_update_wm(struct drm_crtc *unused_crtc) ...@@ -1616,9 +1622,11 @@ static void i9xx_update_wm(struct drm_crtc *unused_crtc)
if (HAS_FW_BLC(dev) && enabled) { if (HAS_FW_BLC(dev) && enabled) {
/* self-refresh has much higher latency */ /* self-refresh has much higher latency */
static const int sr_latency_ns = 6000; static const int sr_latency_ns = 6000;
int clock = enabled->mode.clock; const struct drm_display_mode *adjusted_mode =
int htotal = enabled->mode.htotal; &to_intel_crtc(enabled)->config.adjusted_mode;
int hdisplay = enabled->mode.hdisplay; int clock = adjusted_mode->clock;
int htotal = adjusted_mode->htotal;
int hdisplay = to_intel_crtc(crtc)->config.requested_mode.hdisplay;
int pixel_size = enabled->fb->bits_per_pixel / 8; int pixel_size = enabled->fb->bits_per_pixel / 8;
unsigned long line_time_us; unsigned long line_time_us;
int entries; int entries;
...@@ -1679,7 +1687,8 @@ static void i830_update_wm(struct drm_crtc *unused_crtc) ...@@ -1679,7 +1687,8 @@ static void i830_update_wm(struct drm_crtc *unused_crtc)
if (crtc == NULL) if (crtc == NULL)
return; return;
planea_wm = intel_calculate_wm(crtc->mode.clock, &i830_wm_info, planea_wm = intel_calculate_wm(to_intel_crtc(crtc)->config.adjusted_mode.clock,
&i830_wm_info,
dev_priv->display.get_fifo_size(dev, 0), dev_priv->display.get_fifo_size(dev, 0),
4, latency_ns); 4, latency_ns);
fwater_lo = I915_READ(FW_BLC) & ~0xfff; fwater_lo = I915_READ(FW_BLC) & ~0xfff;
...@@ -1751,6 +1760,7 @@ static bool ironlake_compute_srwm(struct drm_device *dev, int level, int plane, ...@@ -1751,6 +1760,7 @@ static bool ironlake_compute_srwm(struct drm_device *dev, int level, int plane,
int *fbc_wm, int *display_wm, int *cursor_wm) int *fbc_wm, int *display_wm, int *cursor_wm)
{ {
struct drm_crtc *crtc; struct drm_crtc *crtc;
const struct drm_display_mode *adjusted_mode;
unsigned long line_time_us; unsigned long line_time_us;
int hdisplay, htotal, pixel_size, clock; int hdisplay, htotal, pixel_size, clock;
int line_count, line_size; int line_count, line_size;
...@@ -1763,9 +1773,10 @@ static bool ironlake_compute_srwm(struct drm_device *dev, int level, int plane, ...@@ -1763,9 +1773,10 @@ static bool ironlake_compute_srwm(struct drm_device *dev, int level, int plane,
} }
crtc = intel_get_crtc_for_plane(dev, plane); crtc = intel_get_crtc_for_plane(dev, plane);
hdisplay = crtc->mode.hdisplay; adjusted_mode = &to_intel_crtc(crtc)->config.adjusted_mode;
htotal = crtc->mode.htotal; clock = adjusted_mode->clock;
clock = crtc->mode.clock; htotal = adjusted_mode->htotal;
hdisplay = to_intel_crtc(crtc)->config.requested_mode.hdisplay;
pixel_size = crtc->fb->bits_per_pixel / 8; pixel_size = crtc->fb->bits_per_pixel / 8;
line_time_us = (htotal * 1000) / clock; line_time_us = (htotal * 1000) / clock;
...@@ -2913,7 +2924,7 @@ sandybridge_compute_sprite_wm(struct drm_device *dev, int plane, ...@@ -2913,7 +2924,7 @@ sandybridge_compute_sprite_wm(struct drm_device *dev, int plane,
return false; return false;
} }
clock = crtc->mode.clock; clock = to_intel_crtc(crtc)->config.adjusted_mode.clock;
/* Use the small buffer method to calculate the sprite watermark */ /* Use the small buffer method to calculate the sprite watermark */
entries = ((clock * pixel_size / 1000) * display_latency_ns) / 1000; entries = ((clock * pixel_size / 1000) * display_latency_ns) / 1000;
...@@ -2948,7 +2959,7 @@ sandybridge_compute_sprite_srwm(struct drm_device *dev, int plane, ...@@ -2948,7 +2959,7 @@ sandybridge_compute_sprite_srwm(struct drm_device *dev, int plane,
} }
crtc = intel_get_crtc_for_plane(dev, plane); crtc = intel_get_crtc_for_plane(dev, plane);
clock = crtc->mode.clock; clock = to_intel_crtc(crtc)->config.adjusted_mode.clock;
if (!clock) { if (!clock) {
*sprite_wm = 0; *sprite_wm = 0;
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment