Commit 53d35b1a authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau

mt76: improve mcu error logging

Dump mcu command code in hex and related prefix to help debugging
Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent a8333801
...@@ -21,9 +21,8 @@ mt7603_mcu_parse_response(struct mt76_dev *mdev, int cmd, ...@@ -21,9 +21,8 @@ mt7603_mcu_parse_response(struct mt76_dev *mdev, int cmd,
struct mt7603_mcu_rxd *rxd; struct mt7603_mcu_rxd *rxd;
if (!skb) { if (!skb) {
dev_err(mdev->dev, dev_err(mdev->dev, "MCU message %02x (seq %d) timed out\n",
"MCU message %d (seq %d) timed out\n", abs(cmd), seq);
cmd, seq);
dev->mcu_hang = MT7603_WATCHDOG_TIMEOUT; dev->mcu_hang = MT7603_WATCHDOG_TIMEOUT;
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
...@@ -175,8 +175,8 @@ int mt7615_mcu_parse_response(struct mt76_dev *mdev, int cmd, ...@@ -175,8 +175,8 @@ int mt7615_mcu_parse_response(struct mt76_dev *mdev, int cmd,
int ret = 0; int ret = 0;
if (!skb) { if (!skb) {
dev_err(mdev->dev, "Message %ld (seq %d) timeout\n", dev_err(mdev->dev, "Message %08x (seq %d) timeout\n",
cmd & MCU_CMD_MASK, seq); cmd, seq);
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
...@@ -17,9 +17,8 @@ int mt76x02_mcu_parse_response(struct mt76_dev *mdev, int cmd, ...@@ -17,9 +17,8 @@ int mt76x02_mcu_parse_response(struct mt76_dev *mdev, int cmd,
u32 *rxfce; u32 *rxfce;
if (!skb) { if (!skb) {
dev_err(mdev->dev, dev_err(mdev->dev, "MCU message %02x (seq %d) timed out\n",
"MCU message %d (seq %d) timed out\n", cmd, abs(cmd), seq);
seq);
dev->mcu_timeout = 1; dev->mcu_timeout = 1;
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
...@@ -217,7 +217,7 @@ mt7915_mcu_parse_response(struct mt76_dev *mdev, int cmd, ...@@ -217,7 +217,7 @@ mt7915_mcu_parse_response(struct mt76_dev *mdev, int cmd,
int ret = 0; int ret = 0;
if (!skb) { if (!skb) {
dev_err(mdev->dev, "Message %d (seq %d) timeout\n", dev_err(mdev->dev, "Message %08x (seq %d) timeout\n",
cmd, seq); cmd, seq);
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
...@@ -160,7 +160,7 @@ mt7921_mcu_parse_response(struct mt76_dev *mdev, int cmd, ...@@ -160,7 +160,7 @@ mt7921_mcu_parse_response(struct mt76_dev *mdev, int cmd,
int ret = 0; int ret = 0;
if (!skb) { if (!skb) {
dev_err(mdev->dev, "Message %d (seq %d) timeout\n", dev_err(mdev->dev, "Message %08x (seq %d) timeout\n",
cmd, seq); cmd, seq);
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment