Commit 5502ce4e authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown

ASoC: codecs: cs42l42: remove always-true comparisons

Fix W=1 warnings:

cs42l42.c: In function 'cs42l42_handle_device_data':
cs42l42.c:1661:12: warning: comparison of unsigned expression >= 0 is
always true [-Wtype-limits]
 1661 |   if ((val >= CS42L42_BTN_DET_INIT_DBNCE_MIN) &&
      |            ^~
cs42l42.c:1679:12: warning: comparison of unsigned expression >= 0 is
always true [-Wtype-limits]
 1679 |   if ((val >= CS42L42_BTN_DET_EVENT_DBNCE_MIN) &&
      |            ^~
cs42l42.c:1698:23: warning: comparison of unsigned expression >= 0 is
always true [-Wtype-limits]
 1698 |    if ((thresholds[i] >= CS42L42_HS_DET_LEVEL_MIN) &&
      |                       ^~
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200701181320.80848-3-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7fdc1512
...@@ -1658,8 +1658,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client, ...@@ -1658,8 +1658,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client,
ret = of_property_read_u32(np, "cirrus,btn-det-init-dbnce", &val); ret = of_property_read_u32(np, "cirrus,btn-det-init-dbnce", &val);
if (!ret) { if (!ret) {
if ((val >= CS42L42_BTN_DET_INIT_DBNCE_MIN) && if (val <= CS42L42_BTN_DET_INIT_DBNCE_MAX)
(val <= CS42L42_BTN_DET_INIT_DBNCE_MAX))
cs42l42->btn_det_init_dbnce = val; cs42l42->btn_det_init_dbnce = val;
else { else {
dev_err(&i2c_client->dev, dev_err(&i2c_client->dev,
...@@ -1676,8 +1675,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client, ...@@ -1676,8 +1675,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client,
ret = of_property_read_u32(np, "cirrus,btn-det-event-dbnce", &val); ret = of_property_read_u32(np, "cirrus,btn-det-event-dbnce", &val);
if (!ret) { if (!ret) {
if ((val >= CS42L42_BTN_DET_EVENT_DBNCE_MIN) && if (val <= CS42L42_BTN_DET_EVENT_DBNCE_MAX)
(val <= CS42L42_BTN_DET_EVENT_DBNCE_MAX))
cs42l42->btn_det_event_dbnce = val; cs42l42->btn_det_event_dbnce = val;
else { else {
dev_err(&i2c_client->dev, dev_err(&i2c_client->dev,
...@@ -1695,8 +1693,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client, ...@@ -1695,8 +1693,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client,
if (!ret) { if (!ret) {
for (i = 0; i < CS42L42_NUM_BIASES; i++) { for (i = 0; i < CS42L42_NUM_BIASES; i++) {
if ((thresholds[i] >= CS42L42_HS_DET_LEVEL_MIN) && if (thresholds[i] <= CS42L42_HS_DET_LEVEL_MAX)
(thresholds[i] <= CS42L42_HS_DET_LEVEL_MAX))
cs42l42->bias_thresholds[i] = thresholds[i]; cs42l42->bias_thresholds[i] = thresholds[i];
else { else {
dev_err(&i2c_client->dev, dev_err(&i2c_client->dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment