Commit 55c0c530 authored by Gregor Boirie's avatar Gregor Boirie Committed by Jonathan Cameron

iio:magnetometer:ak8975: fix uninitialized chipset

ak_def_array bounds are not properly checked in case of ACPI matching
failure. GCC warns with the following message at line 799:
‘chipset’ may be used uninitialized in this function.
Signed-off-by: default avatarGregor Boirie <gregor.boirie@parrot.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent f0fa15cc
...@@ -774,8 +774,11 @@ static int ak8975_probe(struct i2c_client *client, ...@@ -774,8 +774,11 @@ static int ak8975_probe(struct i2c_client *client,
if (id) { if (id) {
chipset = (enum asahi_compass_chipset)(id->driver_data); chipset = (enum asahi_compass_chipset)(id->driver_data);
name = id->name; name = id->name;
} else if (ACPI_HANDLE(&client->dev)) } else if (ACPI_HANDLE(&client->dev)) {
name = ak8975_match_acpi_device(&client->dev, &chipset); name = ak8975_match_acpi_device(&client->dev, &chipset);
if (!name)
return -ENODEV;
}
else else
return -ENOSYS; return -ENOSYS;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment