Commit 56cd2ed3 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

IB/qib: rename BITS_PER_PAGE to RVT_BITS_PER_PAGE

We get this build warning on arm64

drivers/infiniband/hw/qib/qib_qp.c:44:0: error: "BITS_PER_PAGE" redefined [-Werror]
 #define BITS_PER_PAGE           (PAGE_SIZE*BITS_PER_BYTE)

This is fixed upstream in commit 898fa52b ("IB/qib: Remove qpn, qp tables and
related variables from qib"), which does a lot of other things as well.

Instead, I just backport the rename of the local BITS_PER_PAGE definition to
RVT_BITS_PER_PAGE.

The driver first showed up in linux-2.6.35, and the fixup should still apply
to that. The upstream fix went into v4.6, so we could apply this workaround
to both 3.18 and 4.4.

Fixes: f931551b ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a8d47b4b
...@@ -41,13 +41,13 @@ ...@@ -41,13 +41,13 @@
#include "qib.h" #include "qib.h"
#define BITS_PER_PAGE (PAGE_SIZE*BITS_PER_BYTE) #define RVT_BITS_PER_PAGE (PAGE_SIZE*BITS_PER_BYTE)
#define BITS_PER_PAGE_MASK (BITS_PER_PAGE-1) #define RVT_BITS_PER_PAGE_MASK (RVT_BITS_PER_PAGE-1)
static inline unsigned mk_qpn(struct qib_qpn_table *qpt, static inline unsigned mk_qpn(struct qib_qpn_table *qpt,
struct qpn_map *map, unsigned off) struct qpn_map *map, unsigned off)
{ {
return (map - qpt->map) * BITS_PER_PAGE + off; return (map - qpt->map) * RVT_BITS_PER_PAGE + off;
} }
static inline unsigned find_next_offset(struct qib_qpn_table *qpt, static inline unsigned find_next_offset(struct qib_qpn_table *qpt,
...@@ -59,7 +59,7 @@ static inline unsigned find_next_offset(struct qib_qpn_table *qpt, ...@@ -59,7 +59,7 @@ static inline unsigned find_next_offset(struct qib_qpn_table *qpt,
if (((off & qpt->mask) >> 1) >= n) if (((off & qpt->mask) >> 1) >= n)
off = (off | qpt->mask) + 2; off = (off | qpt->mask) + 2;
} else } else
off = find_next_zero_bit(map->page, BITS_PER_PAGE, off); off = find_next_zero_bit(map->page, RVT_BITS_PER_PAGE, off);
return off; return off;
} }
...@@ -147,8 +147,8 @@ static int alloc_qpn(struct qib_devdata *dd, struct qib_qpn_table *qpt, ...@@ -147,8 +147,8 @@ static int alloc_qpn(struct qib_devdata *dd, struct qib_qpn_table *qpt,
qpn = 2; qpn = 2;
if (qpt->mask && ((qpn & qpt->mask) >> 1) >= dd->n_krcv_queues) if (qpt->mask && ((qpn & qpt->mask) >> 1) >= dd->n_krcv_queues)
qpn = (qpn | qpt->mask) + 2; qpn = (qpn | qpt->mask) + 2;
offset = qpn & BITS_PER_PAGE_MASK; offset = qpn & RVT_BITS_PER_PAGE_MASK;
map = &qpt->map[qpn / BITS_PER_PAGE]; map = &qpt->map[qpn / RVT_BITS_PER_PAGE];
max_scan = qpt->nmaps - !offset; max_scan = qpt->nmaps - !offset;
for (i = 0;;) { for (i = 0;;) {
if (unlikely(!map->page)) { if (unlikely(!map->page)) {
...@@ -173,7 +173,7 @@ static int alloc_qpn(struct qib_devdata *dd, struct qib_qpn_table *qpt, ...@@ -173,7 +173,7 @@ static int alloc_qpn(struct qib_devdata *dd, struct qib_qpn_table *qpt,
* We just need to be sure we don't loop * We just need to be sure we don't loop
* forever. * forever.
*/ */
} while (offset < BITS_PER_PAGE && qpn < QPN_MAX); } while (offset < RVT_BITS_PER_PAGE && qpn < QPN_MAX);
/* /*
* In order to keep the number of pages allocated to a * In order to keep the number of pages allocated to a
* minimum, we scan the all existing pages before increasing * minimum, we scan the all existing pages before increasing
...@@ -204,9 +204,9 @@ static void free_qpn(struct qib_qpn_table *qpt, u32 qpn) ...@@ -204,9 +204,9 @@ static void free_qpn(struct qib_qpn_table *qpt, u32 qpn)
{ {
struct qpn_map *map; struct qpn_map *map;
map = qpt->map + qpn / BITS_PER_PAGE; map = qpt->map + qpn / RVT_BITS_PER_PAGE;
if (map->page) if (map->page)
clear_bit(qpn & BITS_PER_PAGE_MASK, map->page); clear_bit(qpn & RVT_BITS_PER_PAGE_MASK, map->page);
} }
static inline unsigned qpn_hash(struct qib_ibdev *dev, u32 qpn) static inline unsigned qpn_hash(struct qib_ibdev *dev, u32 qpn)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment