Commit 59336e07 authored by Shayne Chen's avatar Shayne Chen Committed by Johannes Berg

wifi: mac80211: make rate u32 in sta_set_rate_info_rx()

The value of last_rate in ieee80211_sta_rx_stats is degraded from u32 to
u16 after being assigned to rate variable, which causes information loss
in STA_STATS_FIELD_TYPE and later bitfields.
Signed-off-by: default avatarShayne Chen <shayne.chen@mediatek.com>
Link: https://lore.kernel.org/r/20230209110659.25447-1-shayne.chen@mediatek.com
Fixes: 41cbb0f5 ("mac80211: add support for HE")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 796703ba
...@@ -2418,7 +2418,7 @@ static void sta_stats_decode_rate(struct ieee80211_local *local, u32 rate, ...@@ -2418,7 +2418,7 @@ static void sta_stats_decode_rate(struct ieee80211_local *local, u32 rate,
static int sta_set_rate_info_rx(struct sta_info *sta, struct rate_info *rinfo) static int sta_set_rate_info_rx(struct sta_info *sta, struct rate_info *rinfo)
{ {
u16 rate = READ_ONCE(sta_get_last_rx_stats(sta)->last_rate); u32 rate = READ_ONCE(sta_get_last_rx_stats(sta)->last_rate);
if (rate == STA_STATS_RATE_INVALID) if (rate == STA_STATS_RATE_INVALID)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment