Commit 59a6ce4f authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] Set d_bucket correctly for anonymous dentries

From: Neil Brown <neilb@cse.unsw.edu.au>

In researching the oopses reported in bug #2761, Neil came up with:

I have found one problem, but it isn't particularly new and I cannot
 see how it would be related.

When d_alloc_anon creates an anonymous dentry, it is put on a special hash
chain for anonymous dentries (sb->s_anon), but d_bucket is set to 

   d_hash(parent, name_hash)

If, when it is eventually moved to a proper name, that hash value is the same
as the final hash value, it will not be moved to the right bucket, and so it
not be accessible by name.  This patch should fix it.



anonymous dentries have their own private hash "bucket" (sb->s_anon) and so
d_bucket should be set to a unique (impossible) address, else d_move will
get confused.
Signed-off-by: default avatarNeil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
parent ab31c400
...@@ -846,7 +846,12 @@ struct dentry * d_alloc_anon(struct inode *inode) ...@@ -846,7 +846,12 @@ struct dentry * d_alloc_anon(struct inode *inode)
res->d_sb = inode->i_sb; res->d_sb = inode->i_sb;
res->d_parent = res; res->d_parent = res;
res->d_inode = inode; res->d_inode = inode;
res->d_bucket = d_hash(res, res->d_name.hash);
/*
* Set d_bucket to an "impossible" bucket address so
* that d_move() doesn't get a false positive
*/
res->d_bucket = dentry_hashtable + D_HASHMASK + 1;
res->d_flags |= DCACHE_DISCONNECTED; res->d_flags |= DCACHE_DISCONNECTED;
res->d_flags &= ~DCACHE_UNHASHED; res->d_flags &= ~DCACHE_UNHASHED;
list_add(&res->d_alias, &inode->i_dentry); list_add(&res->d_alias, &inode->i_dentry);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment