Commit 5a402af5 authored by Tomi Valkeinen's avatar Tomi Valkeinen Committed by Mauro Carvalho Chehab

media: ti-vpe: cal: fix write to unallocated memory

The asd allocated with v4l2_async_notifier_add_fwnode_subdev() must be
of size cal_v4l2_async_subdev, otherwise access to
cal_v4l2_async_subdev->phy will go to unallocated memory.

Fixes: 8fcb7576 ("media: ti-vpe: cal: Allow multiple contexts per subdev notifier")
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 3b3bf0e3
...@@ -607,7 +607,7 @@ static irqreturn_t cal_irq(int irq_cal, void *data) ...@@ -607,7 +607,7 @@ static irqreturn_t cal_irq(int irq_cal, void *data)
*/ */
struct cal_v4l2_async_subdev { struct cal_v4l2_async_subdev {
struct v4l2_async_subdev asd; struct v4l2_async_subdev asd; /* Must be first */
struct cal_camerarx *phy; struct cal_camerarx *phy;
}; };
...@@ -694,7 +694,7 @@ static int cal_async_notifier_register(struct cal_dev *cal) ...@@ -694,7 +694,7 @@ static int cal_async_notifier_register(struct cal_dev *cal)
fwnode = of_fwnode_handle(phy->sensor_node); fwnode = of_fwnode_handle(phy->sensor_node);
asd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier, asd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
fwnode, fwnode,
sizeof(*asd)); sizeof(*casd));
if (IS_ERR(asd)) { if (IS_ERR(asd)) {
phy_err(phy, "Failed to add subdev to notifier\n"); phy_err(phy, "Failed to add subdev to notifier\n");
ret = PTR_ERR(asd); ret = PTR_ERR(asd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment