Commit 5c4fb76a authored by Mark Salyzyn's avatar Mark Salyzyn Committed by James Bottomley

[SCSI] pm8001: fix lockup on phy_control hard reset.

pm8001_phy_control PHY_FUNC_HARD_RESET locks up on second try via
smp_phy_control because response HW_EVENT_PHY_START_STATUS fails to complete
previous command. The PM8001F_RUN_TIME flag is not treated as a bit, but a
state in all readers, yet once we are operational or in the run time state,
the flags use a bit-set operation.
Signed-off-by: default avatarMark Salyzyn <mark_salyzyn@xyratex.com>
Acked-by: default avatarJack Wang <jack_wang@usish.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 46a243f7
...@@ -615,7 +615,7 @@ static int pm8001_dev_found_notify(struct domain_device *dev) ...@@ -615,7 +615,7 @@ static int pm8001_dev_found_notify(struct domain_device *dev)
wait_for_completion(&completion); wait_for_completion(&completion);
if (dev->dev_type == SAS_END_DEV) if (dev->dev_type == SAS_END_DEV)
msleep(50); msleep(50);
pm8001_ha->flags |= PM8001F_RUN_TIME ; pm8001_ha->flags = PM8001F_RUN_TIME;
return 0; return 0;
found_out: found_out:
spin_unlock_irqrestore(&pm8001_ha->lock, flags); spin_unlock_irqrestore(&pm8001_ha->lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment