Commit 5cd4f5ce authored by Christophe Jaillet's avatar Christophe Jaillet Committed by Michael Ellerman

cxl: Fix memory allocation failure test

'cxl_context_alloc()' does not return an error pointer. It is just a
shortcut for a call to 'kzalloc' with 'sizeof(struct cxl_context)' as the
size parameter.

So its return value should be compared with NULL.
While fixing it, simplify a bit the code.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarAndrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: default avatarFrederic Barrat <fbarrat@linux.vnet.ibm.com>
Acked-by: default avatarIan Munsie <imunsie@au1.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 7458e8b2
...@@ -30,10 +30,8 @@ struct cxl_context *cxl_dev_context_init(struct pci_dev *dev) ...@@ -30,10 +30,8 @@ struct cxl_context *cxl_dev_context_init(struct pci_dev *dev)
return ERR_CAST(afu); return ERR_CAST(afu);
ctx = cxl_context_alloc(); ctx = cxl_context_alloc();
if (IS_ERR(ctx)) { if (!ctx)
rc = PTR_ERR(ctx); return ERR_PTR(-ENOMEM);
goto err_dev;
}
ctx->kernelapi = true; ctx->kernelapi = true;
...@@ -61,7 +59,6 @@ struct cxl_context *cxl_dev_context_init(struct pci_dev *dev) ...@@ -61,7 +59,6 @@ struct cxl_context *cxl_dev_context_init(struct pci_dev *dev)
kfree(mapping); kfree(mapping);
err_ctx: err_ctx:
kfree(ctx); kfree(ctx);
err_dev:
return ERR_PTR(rc); return ERR_PTR(rc);
} }
EXPORT_SYMBOL_GPL(cxl_dev_context_init); EXPORT_SYMBOL_GPL(cxl_dev_context_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment