Commit 5df979d6 authored by Stefan Weil's avatar Stefan Weil Committed by David S. Miller

s390: Fix wrong size in memcmp (netiucv)

This error was reported by cppcheck:
drivers/s390/net/netiucv.c:568: error: Using sizeof for array given
as function argument returns the size of pointer.

sizeof(ipuser) did not result in 16 (as many programmers would have
expected) but sizeof(u8 *), so it is 4 or 8, too small here.
Signed-off-by: default avatarStefan Weil <weil@mail.berlios.de>
Signed-off-by: default avatarFrank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d0ff1f52
...@@ -565,7 +565,7 @@ static int netiucv_callback_connreq(struct iucv_path *path, ...@@ -565,7 +565,7 @@ static int netiucv_callback_connreq(struct iucv_path *path,
struct iucv_event ev; struct iucv_event ev;
int rc; int rc;
if (memcmp(iucvMagic, ipuser, sizeof(ipuser))) if (memcmp(iucvMagic, ipuser, 16))
/* ipuser must match iucvMagic. */ /* ipuser must match iucvMagic. */
return -EINVAL; return -EINVAL;
rc = -EINVAL; rc = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment