Commit 5ee70bec authored by ying zuxin's avatar ying zuxin Committed by Helge Deller

fbdev: mmp: Use devm_clk_get_enabled() helpers

The devm_clk_get_enabled() helpers:
    - call devm_clk_get()
    - call clk_prepare_enable() and register what is needed in order to
     call clk_disable_unprepare() when needed, as a managed resource.

This simplifies the code and avoids the calls to clk_disable_unprepare().
Signed-off-by: default avatarying zuxin <yingzuxin@vivo.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent aa578e89
...@@ -512,16 +512,13 @@ static int mmphw_probe(struct platform_device *pdev) ...@@ -512,16 +512,13 @@ static int mmphw_probe(struct platform_device *pdev)
} }
/* get clock */ /* get clock */
ctrl->clk = devm_clk_get(ctrl->dev, mi->clk_name); ctrl->clk = devm_clk_get_enabled(ctrl->dev, mi->clk_name);
if (IS_ERR(ctrl->clk)) { if (IS_ERR(ctrl->clk)) {
ret = PTR_ERR(ctrl->clk); ret = PTR_ERR(ctrl->clk);
dev_err_probe(ctrl->dev, ret, dev_err_probe(ctrl->dev, ret,
"unable to get clk %s\n", mi->clk_name); "unable to get clk %s\n", mi->clk_name);
goto failed; goto failed;
} }
ret = clk_prepare_enable(ctrl->clk);
if (ret)
goto failed;
/* init global regs */ /* init global regs */
ctrl_set_default(ctrl); ctrl_set_default(ctrl);
...@@ -556,7 +553,6 @@ static int mmphw_probe(struct platform_device *pdev) ...@@ -556,7 +553,6 @@ static int mmphw_probe(struct platform_device *pdev)
path_deinit(path_plat); path_deinit(path_plat);
} }
clk_disable_unprepare(ctrl->clk);
failed: failed:
dev_err(&pdev->dev, "device init failed\n"); dev_err(&pdev->dev, "device init failed\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment