Commit 60fb49ca authored by Stephane Viau's avatar Stephane Viau Committed by Rob Clark

drm/msm/mdp5: remove the cfg pointer from SMP struct

We want to make sure we control all the information being passed
down to SMP block. Having access to the cfg pointer here may create
bad things in the future.
Signed-off-by: default avatarStephane Viau <sviau@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent e01b1bfd
...@@ -61,7 +61,7 @@ struct mdp5_smp_block { ...@@ -61,7 +61,7 @@ struct mdp5_smp_block {
int mmb_size; /* MMB: size in bytes */ int mmb_size; /* MMB: size in bytes */
uint32_t clients[MAX_CLIENTS]; /* SMP port allocation /pipe */ uint32_t clients[MAX_CLIENTS]; /* SMP port allocation /pipe */
mdp5_smp_state_t reserved_state;/* SMP MMBs statically allocated */ mdp5_smp_state_t reserved_state;/* SMP MMBs statically allocated */
int reserved[MAX_CLIENTS]; /* # of MMBs allocated per client */ uint8_t reserved[MAX_CLIENTS]; /* # of MMBs allocated per client */
}; };
#define MDP5_INTF_NUM_MAX 5 #define MDP5_INTF_NUM_MAX 5
......
...@@ -90,7 +90,7 @@ ...@@ -90,7 +90,7 @@
struct mdp5_smp { struct mdp5_smp {
struct drm_device *dev; struct drm_device *dev;
const struct mdp5_smp_block *cfg; uint8_t reserved[MAX_CLIENTS]; /* fixed MMBs allocation per client */
int blk_cnt; int blk_cnt;
int blk_size; int blk_size;
...@@ -141,10 +141,10 @@ static int smp_request_block(struct mdp5_smp *smp, ...@@ -141,10 +141,10 @@ static int smp_request_block(struct mdp5_smp *smp,
struct mdp5_kms *mdp5_kms = get_kms(smp); struct mdp5_kms *mdp5_kms = get_kms(smp);
struct mdp5_client_smp_state *ps = &smp->client_state[cid]; struct mdp5_client_smp_state *ps = &smp->client_state[cid];
int i, ret, avail, cur_nblks, cnt = smp->blk_cnt; int i, ret, avail, cur_nblks, cnt = smp->blk_cnt;
int reserved; uint8_t reserved;
unsigned long flags; unsigned long flags;
reserved = smp->cfg->reserved[cid]; reserved = smp->reserved[cid];
spin_lock_irqsave(&smp->state_lock, flags); spin_lock_irqsave(&smp->state_lock, flags);
...@@ -405,12 +405,12 @@ struct mdp5_smp *mdp5_smp_init(struct drm_device *dev, const struct mdp5_smp_blo ...@@ -405,12 +405,12 @@ struct mdp5_smp *mdp5_smp_init(struct drm_device *dev, const struct mdp5_smp_blo
} }
smp->dev = dev; smp->dev = dev;
smp->cfg = cfg;
smp->blk_cnt = cfg->mmb_count; smp->blk_cnt = cfg->mmb_count;
smp->blk_size = cfg->mmb_size; smp->blk_size = cfg->mmb_size;
/* statically tied MMBs cannot be re-allocated: */ /* statically tied MMBs cannot be re-allocated: */
bitmap_copy(smp->state, cfg->reserved_state, smp->blk_cnt); bitmap_copy(smp->state, cfg->reserved_state, smp->blk_cnt);
memcpy(smp->reserved, cfg->reserved, sizeof(smp->reserved));
spin_lock_init(&smp->state_lock); spin_lock_init(&smp->state_lock);
return smp; return smp;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment