Commit 614fe29b authored by Alan Cox's avatar Alan Cox Committed by Jeff Garzik

libata: Spot bridge chips

If we have a PATA cable with a SATA drive on it then we've found a
bridge and we can flip the cable type. This fixes some cable detect
problems with SATA bridges on chipsets and misdetected cable types.

In theory cable detection and mode limiting is needed if you put a
SATA/PATA bridge on a 40 wire cable, but I see no way to deal with
that other than to point out its not a good idea anyway.
Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 4743d085
...@@ -2183,6 +2183,17 @@ int ata_bus_probe(struct ata_port *ap) ...@@ -2183,6 +2183,17 @@ int ata_bus_probe(struct ata_port *ap)
if (ap->ops->cable_detect) if (ap->ops->cable_detect)
ap->cbl = ap->ops->cable_detect(ap); ap->cbl = ap->ops->cable_detect(ap);
/* We may have SATA bridge glue hiding here irrespective of the
reported cable types and sensed types */
ata_link_for_each_dev(dev, &ap->link) {
if (!ata_dev_enabled(dev))
continue;
/* SATA drives indicate we have a bridge. We don't know which
end of the link the bridge is which is a problem */
if (ata_id_is_sata(dev->id))
ap->cbl = ATA_CBL_SATA;
}
/* After the identify sequence we can now set up the devices. We do /* After the identify sequence we can now set up the devices. We do
this in the normal order so that the user doesn't get confused */ this in the normal order so that the user doesn't get confused */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment