Commit 616add70 authored by Mark O'Donovan's avatar Mark O'Donovan Committed by Keith Busch

nvme-auth: unlock mutex in one place only

Signed-off-by: default avatarMark O'Donovan <shiftee@posteo.net>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 37d94868
...@@ -757,12 +757,11 @@ static void nvme_queue_auth_work(struct work_struct *work) ...@@ -757,12 +757,11 @@ static void nvme_queue_auth_work(struct work_struct *work)
__func__, chap->qid); __func__, chap->qid);
mutex_lock(&ctrl->dhchap_auth_mutex); mutex_lock(&ctrl->dhchap_auth_mutex);
ret = nvme_auth_dhchap_setup_host_response(ctrl, chap); ret = nvme_auth_dhchap_setup_host_response(ctrl, chap);
if (ret) {
mutex_unlock(&ctrl->dhchap_auth_mutex); mutex_unlock(&ctrl->dhchap_auth_mutex);
if (ret) {
chap->error = ret; chap->error = ret;
goto fail2; goto fail2;
} }
mutex_unlock(&ctrl->dhchap_auth_mutex);
/* DH-HMAC-CHAP Step 3: send reply */ /* DH-HMAC-CHAP Step 3: send reply */
dev_dbg(ctrl->device, "%s: qid %d send reply\n", dev_dbg(ctrl->device, "%s: qid %d send reply\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment