Commit 618f5df1 authored by Lucas De Marchi's avatar Lucas De Marchi

drm/i915/uncore: Warn only if unclaimed access remains flagged

Commit 4b276ed3 ("drm/i915/uncore: Warn on previous unclaimed
accesses") tried to improve our report of unclaimed register access,
however it unveiled cases that were not previously causing any harm.

Downgrade the first message to debug so we can still see them and
eventually fix, but don't warn.

Fixes: 4b276ed3 ("drm/i915/uncore: Warn on previous unclaimed accesses")
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220408164837.3845786-1-lucas.demarchi@intel.com
parent ce21211b
...@@ -1518,13 +1518,11 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore, ...@@ -1518,13 +1518,11 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore,
const i915_reg_t reg, const i915_reg_t reg,
const bool read) const bool read)
{ {
if (drm_WARN(&uncore->i915->drm, if (check_for_unclaimed_mmio(uncore))
check_for_unclaimed_mmio(uncore), drm_dbg(&uncore->i915->drm,
"Unclaimed access detected before %s register 0x%x\n", "Unclaimed access detected before %s register 0x%x\n",
read ? "read from" : "write to", read ? "read from" : "write to",
i915_mmio_reg_offset(reg))) i915_mmio_reg_offset(reg));
/* Only report the first N failures */
uncore->i915->params.mmio_debug--;
} }
static inline void static inline void
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment